Closed (outdated)
Project:
FullCalendar
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
10 Feb 2011 at 21:51 UTC
Updated:
22 Jan 2018 at 11:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
tim.plunkettThere was discussion of optional integration with beautytips for something like this.
Comment #2
glennpratt commentedWhoops, wrong status...
Patch attached.
Comment #3
glennpratt commentedAhh, nice. I'll look into that.
Comment #4
aspilicious commentedAnd fullcalendar documentation mentions qtip...
Comment #5
aspilicious commentedI'm going to experiment with the qtip stuff
Comment #6
aspilicious commentedI'm going to make a pach for the qtip module. It requires only the code mentioned above and you can style it a bit in the UI of the QTip module. That way we don't have to care about the extra plugin. The only thing I worry about is what we are going to pass into the description... hmm....
The QTip module is far from perfect but it works out of the box (if you like yellow). You can make patches for it if you like to.
Comment #7
aspilicious commentedLike I said before I have some troubles with putting random css and stuff into fullcalendar.
I prefer jquery plugins. (like qtip or others)
I have a D7 patch that is working. Would like some opinions about it.
If you would like to test it you have to patch qtip, I know it sucks, but the D7 port is kinda crap at the moment.
Maybe beautytips uses the same approach so we can insert that one to.. I don't know...
Notes:
1) You can style qtip to get the same result you guys have with your custom code.
2) for some reason only the bottom left positioning is working well... Dunno why...
3) It has a few colorschemes build in (config=>qtip)
4) At the moment the description is empty, wouldn't it be nice if we have a multiselect box to select all the fields we would like to add into our description and in the views preprocess phase we filter the content out of these fields. You can pass html into the description. The description framework is alrdy in this patch, we just need to figure out which fields to pass and how to filter the content.
This is experimental so don't be mad if it would brake something I didn't test...
Comment #8
glennpratt commentedSounds good, I'll take a look as soon as I can. The main driver for me isn't the flyout, but having a way to render arbitrary data (views fields), so passing something to description is the first step.
Comment #9
aspilicious commentedI hacked my way through it to show what I mean. Its ugly because the options are spread between the style and the row options.
But the code is easy and simple.
:D
Comment #10
aspilicious commentedI'm going to expand this experimantal patch to also support beautytips. I misunderstood the module the first time I saw it.
We will see what that will bring :).
Comment #11
aspilicious commentedBeautytip has even worse D7 integration at the moment. It just breaks the site, so I'll have to wait a bit.
But I think I found a nice pattern:
1) In the style settings choose the jquery plugin for tooltips you would like to have (or none if not needed)
- show only the supported plugins that are installed
- hide the other options when you chose one
2) Add ALL the field data into the description (default)
3) If you selected a jquery tooltip plugin show a "Custom description field" into the row settings. Here you can select the fields you would actually like to display into the popup.
(I don't know if it possible to check if you selected a checkbox in an other settings window, we also could display these custom settings if we install on of these libraries)
----------------------------------------------------------------------------------------------------------------------------
Usabilty issue:
- people will have to know that they should configure their description (in an other window!) after enabling a tooltip
SOLUTION:
==> When they select an option, display a description message under the checkbox
"It is advised to configure the discription for your tooltip in your row settings"
ps1: I don't know if you can link to those dynamic pages
ps2: What do you think :)
Comment #12
glennpratt commentedSince we are using a row style with fields, we just render all fields you haven't excluded from display, in-order, in the flyout.
So in the style configuration you map fields to the data that is sent for Fullcalendar, these work even if they are excluded, so you can hide the nid for example from the flyout by excluding it.
Comment #13
aspilicious commentedHmmm... what if I don't want to exclude a particular textfield (I would like to use it to override the title) but would like to exclude it from the description?
Comment #14
glennpratt commentedI assume that configuration (overriding the title) would happen in the view style or row style and wouldn't respect the exclude setting.
Comment #15
aspilicious commentedI'm experimenting with git workflows so me and Tim decided to put this in a sandbox.
You can fetch the code from http://drupal.org/sandbox/aspilicious/1092518 (the test branch, will rename it to flyout)
Comment #16
mherchelSubscribe!
Comment #17
pjcdawkins commentedsubscribing
Comment #18
tim.plunkettThe sandbox is way out of date. Still might be salvageable code though.
Comment #19
aspilicious commentedI'm going to postpone this myself until beautytips or qtips has some reasonable D7 version.
Comment #20
bryancasler commentedsubscribe
Comment #21
itEks commentedGood evening!
Don't prompt, for D6 there is a similar patch?
Comment #22
Tim_MA commentedI'm looking to implement a solution for D7. A summary of what needs to be done would help and any code I get working I will submit back to the community. Thanks.
Comment #23
aspilicious commentedOk what needs to be done.
Beautytips has a stable release now so I suggest looking into that one first.
1) So install beautytips :)
2) Understand http://www.lullabot.com/articles/announcing-beautytips-jquery-tooltip-pl... and the code in http://drupal.org/files/issues/fullcalendar-qtip-experimentalV2.patch (the part in the js file ==> eventrender)
The code I wrote is based on qtip but it follow the same principle.
3) You should also call the beautytips library just before we load the fullcalendar js.
You can use hardcoded values (for background and text color) to start. That's very easy now beautytips got his stable release.
When you got this working you can report back so I can look at your work. :)
I will be available in the #drupal-fullcalendar irc channel for answering questions.
Unassigning myself but will follow this and write some code if needed.
Comment #24
bjlewis2 commentedsubscribing
Comment #25
Tim_MA commentedQuick update as to not leave you in the lurch, this fortunately for us wasn't a show stopper so the client was happy to not to have this feature. As a result we've not had the development time in studio to do this.
However, there is a high chance it'll be picked up in phase 2.
So I'm not actively working on it atm, but watch this space. If anyone else wants to step in please do, it'd make the calendar a lot better.
Comment #26
aspilicious commentedhttp://drupalcode.org/project/fullcalendar.git/shortlog/refs/heads/flyou...
Based on beautytips.
Needs a quick code review.
I need some help:
1) the beautytips look ugly in the calendar, there is a problem with calculating the dimensions, maybe a fullcalendar <-> beautytip conflict.
2) now I print the field name, I need to fetch the field content from the view
Comment #27
aspilicious commentedOk it works :).
I don't filter the seperator yet, this means you can insert html like
(which is nice). But we have to ensure our code is safe.
Anyway it looks nice, one style doesn't work for some reason. But thats a beautytips problem.
Comment #28
tim.plunkettPostponing on #1326772: Devise a way for other modules to add settings to the FullCalendar style options
Comment #29
tim.plunkettStupid dropdown.
Comment #30
matthanh commentedWonderful. Thanks aspilicious.
Now that we have the field names, how would I go about pulling in the field values into the displayed beautytipsText?
Thanks!!
Comment #31
aspilicious commentedSomething is wrong with my module.
And the submit will fail I think because it uses $view which is undefined in that scope.
Comment #32
tim.plunkettAh, found why the JS was completely broken for everything, and why the form wouldn't show.
I changed fullCalendar to fullcalendar already (#1344840: Change fullCalendar in JS to lowercase), sorry about that.
Also, it's hook_fullcalendar_options_form but you forgot the fullcalendar_ part.
It doesn't work straight out of the box, but I'm sure there's some beautytips stuff I'm missing. A library or something.
Comment #33
tim.plunkettComment #34
tim.plunkettComment #35
aspilicious commentedA patch with hardcoded text. Finally I see the positive effect of ctools in here.
I got stuck... :(
Unassigning myself for now as I don't know what to do :)
TODO:
1) Build a list with flyout text based on the select fields.
This list is as long as the events that are going to be rendered.
We need to use that list to print the correct text for each event
2) Verify this all works with ajax turned on.
3) Some tips look funky due to js/css clashes. Verify we can't do anything about that...
POSSIBLE TODO:
When all this works, add qtip integration
Comment #36
tim.plunkettHmm. I'll look at this, see if I can unstick it.
Comment #37
max_d commentedOn a FullCalendar 7.x-2.x-dev, FullCalendar 7.x-2.0-beta3 modules from #31 & #35 has no effect. What there is any way to make a tooltip like this http://philorch.org/concert/calendar ?
Comment #38
acrollet commentedI have to run out, so I can't take this much further, but I at least have the text appearing correctly in popups. patch attached.
Comment #39
acrollet commentedslight update to a comment in the js file.
Comment #40
acrollet commentedAdded dependency on beautytips - promise this is the last patch. I think.
Comment #41
acrollet commentedFixed the options_definition hook invocation (was previously option_definition). Flyout settings are now exported.
no more promises about whether this is the last patch ;)
Comment #42
tim.plunkettThis is looking really close! Haven't tested yet.
If you check http://drupal.org/node/1342772, you'll see that you now get the settings passed to you.
Can you put in { } please?
Comment #43
acrollet commentedthanks for the feedback, updated patch attached.
Comment #44
tim.plunkettLast bit of nitpicks, sorry I didn't see these before.
Missing trailing full stop. And there should still be
Implements hook_fullcalendar_api().in hereMissing the () at the end
I guess this was debug code?
This should use #attached, see http://drupalcode.org/project/fullcalendar.git/blob/refs/heads/7.x-2.x:/... for an example.
Comment #45
acrollet commentedha, no, it was copy-pasted directly from the api doc.
patch attached based on your feedback. Excited about getting this in!
Comment #46
aspilicious commentedI was lacking time, but this was my precious patch. And I'm SOOOO happy someone is finally finishing it.
You're my hero!
Comment #47
acrollet commented@aspilicious: you did the hard part, I just polished it up!
Comment #48
max_d commentedpatch #45 works for me! it's cool! Thank you all!
Comment #49
max_d commentedeverything is fine, but the changes beautytipsStyle and beautytipsSeparator in Options have no effect
Comment #50
acrollet commented@max_d: thanks for the feedback, updated patch attached addressing both concerns.
Comment #51
max_d commented@acrollet, thanks!! now works perfect!!
Comment #52
acrollet commented@max_d: if you're not seeing any more issues with this patch, would you consider marking it rtbc? It'd be nice to get this in...
Comment #53
max_d commentedHi, @acrollet!
what it means to rtbc? I know the language poorly.
patch/module working very good, i not have problems with him.
Comment #54
acrollet commented@max_d: sorry, rtbc stands for Reviewed and Tested By the Community - more explanation here: http://drupal.org/node/156119
Comment #55
max_d commentedok, I understand. As I wrote above - the patch works very well. I can do something to help, except for my response?
Comment #56
aspilicious commentedtrailing whitespace
We have a habbit putting globals on top of a function
2 unneeded spaces in front of element.bt...
Didn't have a chance to test it yet
Comment #57
acrollet commentedpatch attached addressing formatting issues in #56
Comment #58
chunglk commentedUpdate
Comment #59
mherchelIs there a D6 patch available for this functionality? I see a patch in comment #2, but that's over a year ago.
Any ideas?
Comment #60
mstef commented#58 works great - nice work. Some issues..
1) .fc-view has overflow:hidden; which causes tooltips towards the top to get cut off pretty bad.
2) Using a global text views field doesn't work.
3) Selecting a taxonomy field to show in the tooltip results in Fatal error: Cannot use object of type stdClass as array in /var/www/includes/common.inc on line 5723
4) Looks like labels aren't added.
5) Seems like selecting the default style doesn't actually use the default style set in the beautytips admin settings page.
6) Rewrite rules are ignored
Comment #61
tim.plunkett@mikestefff can you leave new comments? It keeps notifying that you updated it but I can't tell what was changed.
Also, needs work.
Comment #62
mstef commentedYea sorry -- I kept thinking I was done, then hoped I was making the edits before anyone saw.
As for the css issue, I think more is needed than what I suggested because the week/day views aren't fixed with that change. I'm also a little nervous to change the overflow setting.
Comment #63
mstef commented7) Can we embed this in the view content, rather than load the javascript settings up with content? The main benefit of that would be caching so this doesn't have to be done every single time.
Comment #64
mstef commentedLine 88 needs to check if $settings['fullcalendar_flyout']['beautytipsFields'] exists and is an array. The code assumes the beautyTips will be enabled for all fullcalendar views.
Comment #65
mstef commentedSame goes for the setting at line 99:
Notice: Undefined index: beautytipsSeperator in fullcalendar_flyout_fullcalendar_options_process() (line 99 of /var/www/sites/all/modules/contrib/fullcalendar_flyout/fullcalendar_flyout.module).
Comment #66
mstef commentedI also don't like the call to module_exists and function_exists every time the module is loaded.
Comment #67
acrollet commentedFWIW, I believe the original author intended to be able to use multiple pop-up libraries and choose between them.
Comment #68
aspilicious commentedWell this should be a seperate "sub" module and that module can have a dependency for the moment on beautytips.
If this works great we can look at a modular system to supprt multiple libraries. When thats done the dependency has to go.
Comment #69
aspilicious commentedI'll be looking at this more detailed in a few weeks. Stay tuned. (I never looked at the recent code) :)
Comment #70
tim.plunkett@mikestefff then you're REALLY not going to like last 100 lines of views.module: http://drupalcode.org/project/views.git/blob/refs/heads/7.x-3.x:/views.m...
;)
Comment #71
mstef commentedboo
Comment #72
mstef commentedMy mistake..looks like the JS settings get cached as well..
Comment #73
mstef commentedYou can get the output to respect the rewrite rules if you use:
Not sure how to get the label settings on there, but this is a good start..
edit: It's throwing errors for some fields..might not be a great idea (yet)
Comment #74
mstef commentedThis works better and makes more sense:
.. I knew there was a function someone in views for this....
$row_index would be the array key added to the first foreach()
Still getting this error though:
Comment #75
mstef commentedI loaded up a few other views, and they all had $view->row_index set (but all set to NULL) -- I'm not sure why this view doesn't have it. Perhaps it's the fullcalendar plugin? Anyway, I just added this to the top of fullcalendar_flyout_fullcalendar_options_process():
Comment #76
mstef commentedAlso only add the flyout field if there's content once it's rendered; otherwise you just enter a useless separator.
(i'll zip this up soon and re-upload)
Comment #77
mstef commentedI need some CSS help -- completely stuck on this issue.
If you set .fc-view to overflow:visible, the month mode works fine.
But, the week (agenda) and day (agenda) are awful because the popups will remain hidden under the edges of the calendar. It seems this is happening because they're set to scroll, and the popup thinks there's space for itself.
Nothing I try seems to help at all..
Ideas?
Comment #78
andrés chandía commentedI see you've been doing a lot of work on this issue, and as I'm not an expert I would like to ask your advice:
Could you give an step by step guide to achieve the use of beauty tips over the fullcalendar, I ask this because I see too many patches, and patches to patches, so I really don't know where to start from.
Thanks for your help
Comment #79
aspilicious commentedI'm going to assign this to myself. If I didn't fix this issue on july 5th, ping me on irc.
Untill than there won't be any step by step guide as this is developpers use only now.
To buggy and untested.
Comment #80
andrés chandía commentedOk, thanks, I will be anxiously waiting
Comment #81
mstef commentedHere's what I got so far.. it could probably use a little cleanup and extra commenting..
Until issue #77 is resolved, I'd consider it unusable.
And this is all based off the great work from #58 (I only tweaked a few things)
Comment #82
aspilicious commentedThat doesn't mean it is unusable I bet there are cases where people can live with this problem the plugin introduces...
Maybe the qtip integration doesn't have this poblem (although I don't think that). We'll see...
Comment #83
aspilicious commentedBtw can you make a patch? With a zip I don't know what is changed between this version and the current version. Else I can't use your code when checking the integration.
Comment #84
mstef commentedWhat's the "current" version exactly? The older zip? Because this was setup as a separate module..
Comment #85
aspilicious commentedThe current version is the 7.x-2-x dev version.
http://drupal.org/project/fullcalendar/git-instructions
Comment #86
andrés chandía commentedSorry, I couldn't wait so long seeing that you're so active....
Well, I have installed the module uploaded at this comment http://drupal.org/node/1057972#comment-6143040 , it works great, the only thing that does not work well for me are the balloons at the calendar block, I mean, they come up as expected, but the visualization is not entire, the balloon get part of it hidden if it goes beyond the block area.
I better attach an image...
Comment #87
aspilicious commentedYeah it is posisble we can't fix that :(.
Comment #88
mstef commented@aspilicious i know what the current version of fullcalendar is. I didn't know if the flyout module would be kept separate or put into fullcalendar.
@andres: Yes, that's the primary issue I mentioned above. You can try setting .fc-view { overflow: visible; } in your CSS. That seems to fix the month mode, but does nothing for the week/day agenda modes. I'm assuming that will cause problems in older versions of IE, also.
Comment #89
aspilicious commentedfor the moment I want to add is a submodule to the fullcalendar package. We will see how it goes.
Comment #90
andrés chandía commentedThanks a lot, it is working like a charm for me now, fortunatelly I only use the month mode at the block.
Thanks, thanks, thanks gurus!
site: http://parles.upf.edu/ca/content/secretaria-fti
Comment #91
aspilicious commentedmikesteff if you're more comfortabe with a sandbox you can create that.
Comment #92
mstef commentedNah, this is fine.. I'm stuck until some css guru can save the day.. which sucks, because I really want this working.
Comment #93
aspilicious commentedCreated new branch. Used code from above with some small modifications and cleaned some useless code.
http://drupalcode.org/project/fullcalendar.git/shortlog/refs/heads/flyou...
I have some questions/problems that I will discus with Tim but this should work just fine (for nodes)
Comment #94
max_d commentedafter upgrade to Drupal 7.15 on my site is no longer working fullcalendar_flyout and http://drupalcode.org/project/fullcalendar.git/shortlog/refs/heads/flyou... too.
Comment #95
andrés chandía commentedSame for me, no more tips at the block calendar view, does anybody knows how to recover them?
Comment #96
andrés chandía commentedI reconfigured all the suff and it's working back, but also is back the problem reported in #86 eventhough I have setting .fc-view { overflow: visible; } in my CSS.
Again help is wellcomed, gurus.....
thanks.
Comment #97
andrés chandía commentedSorry, I forgot to tell you that I have installed the last version from here: http://drupalcode.org/project/fullcalendar.git/shortlog/refs/heads/flyou...
Comment #98
adamtong commentedSorry that i don't know how to use the beatytip and the full calendar? can you step by step telling me?
I have a block showing a mini full calendar with showing some event dates. I would like to mouse over the event date, it show more details like the following site:
http://philorch.org/
http://parles.upf.edu/ca/content/secretaria-fti
Thank you so much in advance!
Comment #99
marcus178 commentedUsing the beautytips solution with ajax enabled doesn't seem to work.
Comment #100
vaccinemedia commentedJust looking into providing a tooltip on fullcalendar and was wondering if this ever progressed? I've downloaded and installed the latest zip file here and installed beautytips but I'm getting the following error when hovering over the calendar events:
TypeError: undefined is not an object (evaluating 'jQuery.bt.vars')
Comment #101
vaccinemedia commentedOK So I've discovered that al the issues I have had have actually been with Beauty Tips and not the way that the patch in this thread allows it to be used. It was all due to me using jQuery update with version 1.8 being applied on the front and obsolete functions in the Beauty Tips JS file as per: https://www.drupal.org/node/1902324 where you'll find a patch which works.
Comment #102
andrés chandía commented