Apparently the action newsletter/confirm/add/(hashvalue) does not work when you click the URL in the confirmation mail. It shows a blank page.
The blank page is due to a wrong API call that is done in the function 'simplenews_confirm_subscription_submit()' :
it says:
return confirm_form('simplenews_confirm_add_form',
$form,
...
);

where the right call is:
return confirm_form(
$form,
...
);

When you corret that code, you get the confirmation form, but when you click 'submit' the intended callback function 'simplenews_confirm_add_form_submit()' is not called, instead it shows the confirmation screen again.

I got it to work again using 2 different forms (one for /add and one for /remove). Patch in attachment...

Comments

patrickharris’s picture

Thank you sponnet - your patch seems to have resolved this issue for me!!

worldcoast’s picture

This gives the same issue as trying to delete a newsletter, it'll take me to the subscribe page now, but will return me to the same page, giving the option to subscribe over and over again.

sutharsan’s picture

Assigned: Unassigned » sutharsan
Status: Needs review » Needs work

I propose to send the user to the home page after subscription/unsubscription.

sutharsan’s picture

Assigned: sutharsan » Unassigned
Status: Needs work » Needs review

After confirmation the user is now redirected to the frontpage. Both for subscribe and unsubscribe.
Confirm unsubscribe is tested. Confirmation of subscription (newsletter/confirm/add) is not tested yet because I could not find this function. :(

sutharsan’s picture

StatusFileSize
new4.43 KB

oops, now with the patch.

worldcoast’s picture

this worked for me.

sutharsan’s picture

Status: Needs review » Reviewed & tested by the community
sutharsan’s picture

Status: Reviewed & tested by the community » Fixed

After checking various recent patches this patch is not required anymore. The problem fixed by the combination of patches which are now committed to 5-1-dev.

Anonymous’s picture

Status: Fixed » Closed (fixed)