Closed (fixed)
Project:
Image Publishing
Version:
master
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
30 Dec 2006 at 20:38 UTC
Updated:
27 Jul 2007 at 13:21 UTC
Jump to comment: Most recent file
Will anyone be working on updating Image Publishing for compatibility with Drupal 5.0?
| Comment | File | Size | Author |
|---|---|---|---|
| #28 | image_pub_1.txt | 15.39 KB | bwynants |
| #26 | image_pub_0.txt | 32.16 KB | edwardrapley |
| #24 | image_pub.txt | 32.02 KB | edwardrapley |
| #20 | patchfile_4.patch | 5.55 KB | bwynants |
| #16 | image_pub.module.txt | 32.09 KB | robloach |
Comments
Comment #1
robloachI've updated the Image Publishing module to Drupal 5.0 RC1, and attached the patch here. Would someone please commit it?
Comment #2
robloachMake sure you don't forget the attached image_pub.info file.
Comment #3
Tobias Maier commentedsmall nitpick:
code like this
should be
Comment #4
robloachGood find..... I've included the .info file in this patch.
Comment #5
oliver soell commentedworks for me
Comment #6
genemcc commentedtracking
Comment #7
charly commentedseems to work here too
Comment #8
bradsw57 commentedInstalled HEAD tarball on Drupal 5.1 with image 5.x-1.x-dev, gallery 5.x-1.x-dev, clean URLS.
Gallery Remote 1.5 and later cannot connect. (have not tried earlier versions).
Page not found errors with URL "http://www.bradmarg.homeip.net/main.php?g2_controller=remote.GalleryRemo..." present in the Drupal message log.
apache error log contains "script '/var/www/drupal/gallery_remote2.php' not found or unable to stat"
Website is at http://www.bradmarg.homeip.net (it's on a slow link, so please be nice :))
Comment #9
charly commentedI can confirm it doesn't work :/
I have the same error in apache logs, but none in drupal logs..
Comment #10
bradsw57 commentedMy bad.
The Gallery module puts some mod_rewrite code into .htaccess, which catches the gallery_remote2.php url before it gets to the module. Removed the rewrite rule and it's all good.
Comment #11
charly commentedSeems strange since i don't use the Gallery module.
Can you explain a bit more?
Comment #12
bradsw57 commentedFollowed up via email.
In short, the line
"RewriteCond %{REQUEST_FILENAME} gallery\_remote2\.php"
that the gallery module puts into .htaccess needs to be removed for this module to work, I think.
Comment #13
Wimmmmm commentedCould someone include the whole install package here please?
I don't want to get into CVS patches just for a 5 or 6 kb file... and HEAD is not updated (looking at http://drupal.org/node/63154/release )
Thanks!
Wim
Comment #14
KMNL commentedCould someone post a zip here and we can all test before its released?
Comment #15
Bevan commentedPlease
Comment #16
robloachYou'll also need image_pub.info:
I just tested it with Drupal 5.1 and it seems to be working.
Comment #17
Bevan commentedtks
Comment #18
jody lynnI'm really glad to see the Drupal 5 version is coming out! This is a very cool module. Thanks everyone who has worked on it!
Comment #19
zach harkey commentedWorking fine here on 4 production sites.
Comment #20
bwynants commentedshould become
to give comments the proper default value
should become
node_submit is important for some module depending on hook_submit (organic groups)
should become
typo
see also http://drupal.org/node/70841
newe patch added
Comment #21
dsnydernc commentedThis thread is a mess! So many patches, and patches to patch broken patches, and no explanation as to what should originally be patched (4.7 release or head). Can someone please either update the head ver. with the appropriate patches, or provide a link to download the functioning 5.x module? Too confusing...
Comment #22
bwynants commentedversion specified on top of this Issue is head so patches should be applied on a clean head version....
Comment #23
grendzy commentedI just tested the patchfile_4.patch above (applied to HEAD). It works great! Thank you so much. I'm exporting from iPhoto with iPhotoToGallery. This totally made my day.
Comment #24
edwardrapley commentedI really like the functionality of gallery remote, and I've got a lot of images to upload for a site I'm making so i have sent a bit of time figuring out how to get this module working.
OK, so i know absolutely nothing about programming.
I've given myself a nose bleed and a migraine from trying to work out what needs doing and how to do it and then spent 4 hours trying to find out how the numbering of the lines is organized. When all i needed to add was a " ; " in the right place.
I have manually applied patchfile_4.patch to the HEAD version and then added the .info file to the folder and uploaded it all.
So now it the module is enabled, it appears in all the right places in the admin, and since i put the " ; " in it isn't generating fatal errors, but it isn't working.
I'm using Gallery Remote 1.5 ( http://gallery.menalto.com/wiki/Gallery_Remote ) and all i get when i put in the URL for the Drupal root is a message saying: Gallery Remote can find no protocol implementation at http://www.edwardrapley.co.uk. Check with a web browser that http://www.edwardrapley.co.uk is a valid gallery URL.
anyone know what the problem might be?
I've attached the patched module file, maybe the problem is in there?
Comment #25
grendzy commentedThe patch files are meant to be machine-readable. Were you trying to edit the module file manually? Sorry if this is a stupid question, I'm just wondering why you were trying to figure out the numbers in the patch file.
Normally, a patch is applied like this (from a unix-like shell):
# patch image_pub.module < patchfile_4.patchHopefully there will be a 5.x release soon, but in the meantime try the "patch" program.
Comment #26
edwardrapley commentedI've patched in the couple of lines about deleting the temp files and I have reworded the syntax of a couple of lines as suggested by Tobias Maier.
Now when I enter URL for Drupal root i get: this error message: Error: HTTP POST failed (HTTP 404 Not Found)
DEVELOPMENT! Following a post i found which i can't locate now, i removed the whole section generated by my previous gallery2 installation in the .htaccess file and now Gallery Remote works!
All the features seem to be working, photos uploading very nicely. Now i just wonder if the meta tags or taxonomy can be set from Gallery Remote?
Comment #27
edwardrapley commentedI have now installed the image_pub to 3 sites. It works perfectly on the first one.
But with the other two sites it accesses the galleries fine, however it sees them as read only so i can't create new galleries or upload photos with Gallery Remote.
The sites are running on the same versions of image (5.x-1.0) and image_pub (5.x-1.x-dev).
I've noticed this problem come up a few times in previous treads about this module but i haven't seen anyone suggest reasons for it happening or how to solve it. Any suggestions?
Comment #28
bwynants commenteduncomment the part after
in your settings.php file.
it's a problem with the session ID
attached (rename to zip) the last version I have will all known patches. Can somebody commit this?
Comment #29
Stuart Greenfield commentedI'm still getting to grips with PHP Eclipse and it's making weird patches, but I've changed line 246 from
to
so that a new image respects publish status, promotion, stickiness and revision status settings.
This is a great module - I'm using it all the time now to upload images :)
Comment #30
bwynants commentedThe maintainer of the module is on holiday. I can not commit changes in this project. therefor I placed the latest version in an archive on the web
All changes/fixes here have been committed to that archive.
The 5.0 module can be found on http://www.goju-ryu.be/image_pub.zip
Comment #31
asciikewl commentedDid this quick change to get image_pub working with image 1.3: