Hi - thanks for the useful module. Here's my feature request.

It would be very useful to add a filter to add only content that has been "Published" to a featured content block. Here's my use case: I use the Modr8 module to sort user-submitted content, but as it is, the Featured Content module shows the content in its list even if it has not been published yet.

Thanks - Alex

Comments

kristen pol’s picture

Assigned: Unassigned » kristen pol

Hmmm.. I thought I was only showing published nodes! I will fix that soon.

Kristen

kristen pol’s picture

Category: feature » support

I just looked at the code and I've got:

n.status <> 0

in the sql. Perhaps this is missing for your particular case. Can you please create a screenshot of your settings using something like ScreenGrab?

Thanks,
Kristen

kristen pol’s picture

Status: Active » Needs review

I went through all the queries. There was one that was getting nodes based on user that was not only getting published nodes so I updated that query. All the rest were only getting published nodes. So, I'm assuming your FC block was getting all nodes for a particular user. If not, then please send the screenshot of the settings page.

I have checked in my change and it will be available in the dev version once the cron job does it's update. Please test.

Thanks,
Kristen

Satri’s picture

Hi Kristen - thanks for the quick followup.

I found the problem. It's with the way the Modr8 module works. Nodes that awaits moderation in Modr8 *have* the flag "Published" but also have a "In moderation queue" flag (directly in the "Publishing options" too).

In order to bring compatibility between the Modr8 and Featured_Content modules, I guess FC could filter out nodes with the "In moderation queue" flag?

What do you think? - thanks

Satri’s picture

Title: Add a 'Published' filter » Compatibility with the Modr8 module
Category: support » feature
Status: Needs review » Active

Renamed the issue title to reflect the real problem.

kristen pol’s picture

Status: Active » Postponed
kristen pol’s picture

The moderate column was removed from the db schema in D7:

http://drupal.org/node/564462

so this would need to be carefully considered.

Kristen

kristen pol’s picture

Status: Postponed » Fixed

I added code to check if the modr8 module is being used and, if so, it checks if the moderate column exists and, if so, then it only keeps the nodes that have moderate=0. Please test.

Kristen

Satri’s picture

Thanks Kristen - how do you want us to test? Is there any patch? The 6.x-dev version is old and certainly does not contain your recent fix. I'll be glad to test your latest version once I know where I can find it :-)

kristen pol’s picture

Ah, thanks for the reality check... I had done a "gitpush" which was an alias for "git push" to push the code in but it was tied to a specific client project so it didn't work! I have fixed all that and did a real "git push"... meaning it should be bundled up any minute by drupal.org.

Thanks for your patience!
Kristen

kristen pol’s picture

Status: Fixed » Closed (fixed)

This has been included in 6.x-1.3. It will not be in the D7 release because there is no moderate column in D7.

Kristen

Satri’s picture

Please allow the delay Kristen, I've been overly busy this week. I installed 1.3 this morning and I confirm it does work! The Feature Content module is now compatible with the Modr8 one. Thanks a lot.

kristen pol’s picture

Assigned: kristen pol » Unassigned
Issue summary: View changes

cleaning up my issues list