we used to have a local modification to project.module on d.o such that instead of the download links pointing to http in the files directory, we always sent the links to ftp. this helped for 2 reasons: 1) it offloaded work from httpd and made the downloads ftpd's problem; 2) it made it easier to do download stats.
sadly, this modification got lost in the transition to the new release system, but we want it back...
however, having this as a local change in the live workspace, without being in CVS or in a patch, is a pain to maintain. plus, other sites might want this.
so, i'm going to add a new admin setting in project_release.module to specify the proper "base URL" for download links. if not defined, we default to the current behavior. else, we do what it says. i'll add a project_release_download_link() function to hide the details so we can put all the logic in one place and only change the call sites once.
stay tuned for a patch...
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | project_release_download_base_D5.patch.txt | 5.53 KB | dww |
| #1 | project_release_download_base.patch.txt | 5.32 KB | dww |
Comments
Comment #1
dwwComment #2
dwwversion for 5.x
Comment #3
dww#2 now installed on s.d.o, and setting defined. seems to be working fine.
anyone care to review?
Comment #4
dwwreviewed by greggles in IRC. committed to DRUPAL-4-7--2 and HEAD, and installed on d.o and s.d.o respectively.
Comment #5
(not verified) commented