This patch enables the print friendly module to work with Drupal 5.0 RC1.

Byte

CommentFileSizeAuthor
#4 patch63 KBByteEnable
#2 print3.patch.txt1.76 KBByteEnable
#1 print.patch21.96 KBByteEnable
print.patch.txt1.86 KBByteEnable

Comments

ByteEnable’s picture

ByteEnable commented
StatusFileSize
new print.patch21.96 KB

Fix patch file per Drupal patch rules.

ByteEnable’s picture

ByteEnable commented
StatusFileSize
new print3.patch.txt1.76 KB

One more try on the patch file.

Byte

ByteEnable’s picture

ByteEnable commented
Status: Needs review » Needs work

The patch still needs work, it doesn't work with clean URL's.

ByteEnable’s picture

ByteEnable commented
Status: Needs work » Needs review
StatusFileSize
new patch63 KB

This patch should work with/without clean-urls and/or path aliasiing.

Byte

nedjo’s picture

nedjo
he/him/his
Primary language English
commented
Status: Needs review » Needs work

Thanks for taking on the work of updating.

Could you explain the menu changes you've made? Why the custom handling of arguments? Why doesn't arg() work here? What has changed in Drupal 5 that necessitates this change? The old version looks like it should still work fine.

The 'admin/content/print' menu item should be in $may_cache, not !$may_cache.

Indenting should be done with double spaces rather than tabs.

ByteEnable’s picture

ByteEnable commented

The old version didn't work with pathauto, clean url's and drupal 5. The arg(0) function only returns part of the path, arg() returns null. I guess you could use a while loop to build up the query thats contained in $_get['q'].

Yeah the cache thingy, forgot. I had it not cached for testing if I remember correctly. I have been working on some non-Drupal code, so my brain functions like a FIFO :).

genemcc’s picture

genemcc commented

Tracking

spooky69’s picture

spooky69 commented

As above.

flanderz’s picture

flanderz commented

ping

hunmonk’s picture

hunmonk commented

dang folks, why are we doing double work here??

http://drupal.org/node/88162 -- this patch has been in the queue for nearly four months, and i've been using that update on a drupal 5 site for quite awhile now, with no issues!

let's mark one of these a duplicate...

yngens’s picture

yngens commented

patch6 works with 2 problems for which I have found my solutions:

1. logo does not show - since I don't know correct sinI sintaxis I just put in print.node.tpl.php file actual URL to my logo
2. text shows without any break lines - in the same file I changed

print $node->body; to
print nl2br($node->body);

I hope this helps somebody.

yngens’s picture

yngens commented

the same problems applies to http://drupal.org/node/88162

mariagwyn’s picture

mariagwyn commented

Can this be put into the HEAD so it can be downloaded as a 5.0 module?

Thanks,
Maria
(also commented on http://drupal.org/node/88162)

drewish’s picture

drewish commented
Status: Needs work » Closed (duplicate)

yeah, this is totally a duplication: http://drupal.org/node/88162