attached patch updates the module to 5.0

also fixed in this patch, the default logo display was not working, because the printer friendly callback didn't contain anything that initialized the theme, therefore the theme_get_setting('logo') call was returning a bad path to the logo.

.info file to follow...

CommentFileSizeAuthor
#4 print_4_0.patch2.87 KBWill White
#1 print.info127 byteshunmonk
print_3.patch2.89 KBhunmonk
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

hunmonk’s picture

FileSize
127 bytes

.info file

mariagwyn’s picture

Can this be put into the HEAD so it can be downloaded as a 5.0 module?

Thanks,
Maria
(also commented on http://drupal.org/node/106261)

mathieu’s picture

subscribing.

Will White’s picture

FileSize
2.87 KB

Here's another iteration of the patch. I adjusted the capitalization as per http://drupal.org/node/64279#sentence_capitalization

Otherwise, it functions well.

JohnG-1’s picture

+1 for DRUPAL5 branch 5.x-1.x-dev release :)

charmer’s picture

I have successfully patched 4.7 version of print module with print_4_0.patch above into my Drupal 5 and can confirm that it works.

I guess new release is imminent.
Thanks!

Bevan’s picture

Title: update to 5.0 » Release for drupal 5.0
Status: Needs review » Reviewed & tested by the community

Who maintains this module? It'd be nice to get it released officially for drupal 5.

JohnG-1’s picture

I've just applied patch_4 to the last 4.7.x version of print.module.

some minor bugs?:

  1. The patch should remove the closing PHP tag ?> from the last line (385) of the 5.x print.module ... after I did this it stopped giving me errors like this:
    warning: Cannot modify header information - headers already sent by (output started at /home/username/public_html/drupal5/sites/all/modules/print/print.module:385) in /home/username/public_html/drupal5/includes/common.inc on line 141.
    
  2. Couldn't find the print module settings in the /admin/by-module page. (missing a D5 hook?)
  3. 'Source URL' links are corrupted : eg http://example.com/drupal5/drupal5/node/4 [= Drupal Page Not Found ]
    It may have something to do with my using the 'drupal5/sites/all/modules' directory rather than the more common 'drupal5/modules' ?
    It may have to do with other $base_url issues with Drupal that I'm now becoming dimly aware of ... ?
      /* Grab and format the src URL */
      $node->source_url = $base_url . url("node/$node->nid");
    ...
      $source_url = $base_url . substr($_GET['q'], 5);
    ...
    

Otherwise it seems to be working well enough.

Any feedback / suggestions welcome :)

hunmonk’s picture

Title: Release for drupal 5.0 » update to 5.0
Status: Reviewed & tested by the community » Fixed

applied to HEAD. DRUPAL-5 branch and first release to follow shortly

Anonymous’s picture

Status: Fixed » Closed (fixed)