Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.The logic on this check was recently reversed. However, it isn't really needed. It only is relevant if you have a 1-column homebox with width: 100%. It appears it was trying to save some time by not changing height in that case. Equalizing the height of one column to itself shouldn't be a problem. This sort of check just slows down the common case, multiple columns. Needs testing.
| Comment | File | Size | Author |
|---|---|---|---|
| homebox.d7.patch | 1019 bytes | drumm | |
| homebox.d6.patch | 973 bytes | drumm |
Comments
Comment #1
brianV commentedTested, this works well. I'll apply these tomorrow.
Comment #2
brianV commentedComment #3
brianV commentedFixed in 7.x-2.x and 6.x-3.x:
http://drupal.org/cvs?commit=501560
http://drupal.org/cvs?commit=501558
Comment #4
brianV commentedComment #5
brianV commentedReverted due to #955072: Make Homebox only equalize heights of columns within the same row..
In the use case where there are multiple rows of columns, all columns are sized to the height of the tallest column, even if it is not in the current row.
While this patch did not create this problem, it does amplify it; the width checks that were removed prevented 100% width columns from being resized to the height of the tallest column.
The proper solution would be to assign columns to rows, and then only equalize columns within their respective rows.
Comment #6
brianV commentedComment #7
brianV commentededit: Err, just to note - I reverted the patch, but I did fix the previously introduced logic error where the .match() results should check for 'null'.