Define hooks on subscribe/unsubscribe user

I'm affecting this to myself, so I think about reviewing it.

Code looks clean & simple enough.

Typo in the title ;)

Ok, I've looked at your patch :

• Wouldn't it make sense to have the hook fired at the same time of the action Trigger (I'd move the line inside the elseif loop just two lines up) ?
• Or did you make it fired for the confirmation part as well to update external system eventually ?

Ok, I see.

@miro_dietiker, @Sutharsan, do you see something preventing this addition (a matter of performance, maybe, or something else I'd be missing) ?

Committed to 6.x-2.x.
Let's see if someone complains ;-)

Patch for 7.x-1.x

Committed.

Wondering if it's too late to complain :)

The implementation in D6 is unusable: there's no info about the subscription passed through to the hooks. Attached patch mimics the same behaviour as in D7. It also takes care of #4.

btw, actions integration is broken in the same way, although it is not my battle and I've also heard that actions are gone in D7 version in favour of rules.

It's never to late to complain if you provide a patch :)

Changes look good to me. The variable rename is unfortunate, but probably necessary. FYI, simplenews_get_subscription() is gone in 7.x in favor of simplenews_subscriber_load_*() functions (they're not entities though, but that will most likely happen for 7.x-2.x)

Yes, actions integration is gone in 7.x and I'm not sad about that ;)

Yes, I did read 7.x before proceeding with this patch. The variable rename is in concordance with 7.x. It is unfortunate, but isolated in the involved functions.

Is the test bot stalled or just tests for simplenews that doesn't fire?

There're some failures with this patch

There are more than just some failures without this patch as well :)

The 6.x tests are completely broken, that's why the testbot postpones testing of your patch until those tests are fixed. Unless you can manually confirm that there are *more* test failures with your patch than without, you can safely ignore them.

I once started backporting the current 7.x-1.x tests to 6.x-2.x but it's quite a bit of work. If you're interested in that, ping me and I can give you what I came up with.

Here is a better patch.

I'm not excited about working on tests by now, but I will continue posting patches as bugs hit me.

A bug related to this patch found. Confirmation link was bad.

Prehaps I need those tests though. Berdir, please expose those tests to me by the mean you consider more convenient.. mail, issue, git branch...

The backport of the tests is now available in #1532122: Backport of the 7.x-1.x tests, your patch should automatically be picked up by the testbot once they are commited and the branch tests pass.

test passes. I'll try to provide a test to cover this hooks.

Patch in #18 makes perfect sense, and passes the simpletest.. ready for commit?

supporting commit of this patch

Has this patch ever been rolled into the D6 version?