Posted by sukr_s on February 22, 2011 at 5:57pm
4 followers
| Project: | Ubercart |
| Version: | 6.x-2.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
when the domain access is enabled and each site has it's own site logo, the invoice takes the logo from the wrong site.
1. create a site 1 e.g. site1.mysite
2. create a second site 2 e.g. site2.mysite
3. choose different default themes for each of the sites from admin -> site building -> domains -> (theme link for the domain)
4. set different logos for each of the site
5. now place an order in site 2 and view the order
6. click on invoice tab. the logo of site 1 is shown instead of site 2's logo
Comments
#1
I'm providing the patch that resolves this issue. would be great if someone could review and integrate the patch.
#2
The wrong logo will still be displayed if you place an order on site 2, then go to site 1's admin pages and view the order. http://drupal.org/project/uc_domain fixes this issue and also other issues with order tokens so the invoice is always correct for the domain where the order was placed.
#3
Hm, but $theme_key could still be a better way of finding the current domain than using variable_get(). I will look at this further when I get time, but uc_domain is still the better solution for using Domain Access with Ubercart.
#4
Let's get the bot to test this.
#5
#6
The last submitted patch, ubercart-1069590.patch, failed testing.
#7
Committed a simplification for the site-logo token in http://drupalcode.org/project/ubercart.git/commitdiff/b150b22 which fixes this issue. The original code copied theme_get_setting(), but instead we can just call theme_get_setting().
#8
Automatically closed -- issue fixed for 2 weeks with no activity.