Upgrade for drupal 5.0.
Tested in 5.0rc1, need review.

CommentFileSizeAuthor
#7 flash_gallery.zip_.txt32.58 KBBevan
flash_gallery_5.0.patch3.34 KBjimyhuang

Comments

kreynen’s picture

Category: task » bug

The .info file created by this patch has version = "$Name$". Shouldn't it be version = "5.x-1.x-dev" or "5.0-rc1"?

kreynen’s picture

In the main fgallery list, "There are %count images in this gallery"

stephane bouillet’s picture

Seems working for me
thank you
;)

silurius’s picture

Newbie question: could you please provide (or link to) basic instructions for applying this patch?

pazonada’s picture

i'll echo the other newbie request: i can't seem to get any version of fgallery to even show up in my modules. i followed the installation, also uploaded the flash_gallery_5.0.patch file to the modules/flash_gallery, but don't know if there's some other step i'm missing. both image.module and image_gallery.module are enabled. advice is appreciated!

sime’s picture

Status: Needs review » Closed (won't fix)

Hi jimyhuang

Sorry for the work that has gone into this, but I won't be releasing a standalone version of Flash Gallery for D5.

You are not being abandoned, the module will be ported under SWF Tools. I am simply apologizing for the effort you've put in to converting the whole module. I would commit the code, except this would be a duplication for 5 and create an expectation of support.

Please refer to http://drupal.org/node/116077 to read about porting efforts and to ask questions about the changes.

Regards
Simon

Bevan’s picture

StatusFileSize
new32.58 KB

I've patched Feb 07's 4.7.x-1.0 official release with jimyhuang's flash_gallery_5.0.patch, installed simpleview as per instructions on http://www.endymios.com/flash-gallery-module#installation, zipped the folder and attached.

I haven't done this in ignorance of simon's comment (http://drupal.org/node/107303#comment-192505). I'm aware that this module won't officially be ported to drupal 5, but that the effort is being ported to SWF tools, http://drupal.org/project/swftools.

Unfortunately SWF tools doesn't seem to have a working equivalent of this module yet (at least from what I could gather in their limited issues and CVS). So I've done this as a temporary measure until SWF tools provides a 'blessed' and better way of doing this.

Please don't take offense Simon.

Regards,
Bevan/

Bevan’s picture

there seem to be two small issues with the patched version:

ONE
On /fgallery under the gallery title %count is not parsed: "There are %count images in this gallery" (Except when there is only one image)

TWO
on image upload, flash_gallery.module SOMETIMES returns these errors:

    * The selected file /Users/bevan/Sites/bwm.lcl/files/images/gallery/2006_(9).thumbnail.jpg could not be copied, because no file by that name exists. Please check that you supplied the correct filename.
    * warning: copy(sites/bwm/files/images/gallery/2006_(9).thumbnail.jpg) [function.copy]: failed to open stream: No such file or directory in /Users/bevan/Sites/bwm.lcl/modules/flash_gallery/flash_gallery.module on line 394.

however I can't consistently reproduce this second one.

sime’s picture

Bevan: no offence I'm taking. I support people getting a version 5 to work.

robotjox’s picture

Hi, I get the "...could not be copied..." error too using the patch. Any ideas on how to fix it?

Bevan’s picture

Don't know sorry. I haven't investigated any further yet. I'll let you know If i find a solution.

B/