http://drupal.org/cvs

Seems like the first click works, the second click doesn't.

The url
http://drupal.org/cvs?from=30&q=cvs&from=20
has from= twice.

CommentFileSizeAuthor
#3 cvs-fix-pager-2.patch723 bytesTDobes
#2 cvs-fix-pager.patch688 bytesTDobes

Comments

TDobes’s picture

TDobes commented
Project: Drupal.org site moderators » CVS integration
Component: web site » Code

Reclassifying as a cvslog.module bug.

TDobes’s picture

TDobes commented
Assigned: Unassigned » TDobes
StatusFileSize
new cvs-fix-pager.patch688 bytes

I've attached a patch which seems to fix the problem for me... there may be a more efficient solution by unsetting the values directly in the $_GET superglobal, but I was hesitant to do this, as it may cause side effects elsewhere.

Please review and/or apply before the next update of drupal.org, as this seriously limits the usability of the web-based cvs messages.

TDobes’s picture

TDobes commented
StatusFileSize
new cvs-fix-pager-2.patch723 bytes

Whoops... here's an updated patch. It supercedes the previous one.

As the repository parameter becomes part of the path (not an attribute), it shouldn't be passed to the pager either.

Anonymous’s picture

(not verified) commented
Title: drupal.org/cvs pagination broken » cvs log pagination broken

For an example of the problem, navigate to the drupal.org cvs log and attempt to click "next page" twice in a row. You'll notice that you get two "from" parameters in the URL in addition to an unnecessary "q" parameter.

TDobes’s picture

TDobes commented
Anonymous’s picture

(not verified) commented