Closed (outdated)
Project:
Drupal core
Version:
7.x-dev
Component:
system.module
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
8 Jan 2007 at 13:45 UTC
Updated:
4 Feb 2021 at 09:15 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
morbus iffThe previous behavior of Garland was to force the description table column to 100% (which seems evil to me, but I'm no CSS mastah). This patch removes that and adds a width to the Name column, letting everything else render as the browser sees fit.
Comment #2
morbus iffAfter installing some more popular modules, like CCK, Views, and ConTemplate, this mix of 20/80 worked better.
Comment #3
morbus iffComment #4
webchickStill applies with offset.
Looks good to me. I had to ask Morbus to clarify what this does, and basically...
When your window is shrunk down very small, and you gradually expand it, before the patch it would only expand the "description" field... now it also expands the name field, so multi-word module names ("project issue tracker" on my install) will not wrap quite so much.
+1.
Comment #5
Steven commentedIf we want to avoid wrapping, why not set nowrap?
Comment #6
morbus iffWe want the ability to let screen width determine the wrapping for elements, not "don't allow wrapping evah". The display of text on a site should be as malleable as possible based on a resizing window - allowing only one element to wrap (what this patch fixes) or disallowing wrap at all (what you suggest) is bad form. While I could certainly see some benefit in forcing Name not to wrap, I can equally see myself complaining about how 10 lines of description looks like ass when I happen to have my window set to 750px wide (which, yes, I occasionally do when I'm reading).
Comment #7
Steven commentedBut the page looks a lot neater if module names are always next to the checkbox :P. It is the primary column in the table after all.
Comment #8
morbus iffSo, you'd advocate a patch that a) gave all the columns class names (as the previous patch did), b) set nowrap on the 'name' column and c) ???. c) could be either leave description at 100% (as before) or don't give it a width at all, and let the browser figure it out (potentially causing odd displays with Version and Throttle columns).
Comment #9
drummComment #10
moshe weitzman commenteddunno if is related, but this page shows empty module list in Safari right now.
Comment #11
dww@moshe: no, that's a separate bug, and is specific to jQuery badness: http://drupal.org/node/134307
Comment #12
morbus iffSteven's comments in #8 need to be addressed.
Comment #13
jody lynnComment #14
sunThis might be part of #1790280: Module page redesign 2.0 already, but not sure.
Comment #15
mgiffordI kinda assume this has been fixed as part of the responsive theming work that has been done. Not sure though.
Comment #24
quietone commentedI tested this on a standard install of drupal 7.79-dev and Drupal 8.9.0 by navigating to /admin/modules
On Drupal 8.9.0 the modules of more than one word do not wrap but some do on Drupal 7.
Therefor, moving to the Drupal 7 issue queue.