Disabled taxonomy fields when enabling and disabling i18n_taxonomy

It seems i18n_taxonomy "takes over" taxonomy fields. Looking for a way of resetting them ater disabling the module.

Same issue for me, additionally i18n_taxonomy seems to take over the taxonomy field views integration, but I'm going to file an other issue for that matter, once I'm definitely sure of it and can provide fast and easy steps to reproduce.

When you create a taxonomy vocabulary with Taxonomy translation module enabled the value in "field_config" table for the field type "taxonomy_term_reference" is: i18n_taxonomy. Even when you disable the module, it's never set back to the original taxonomy, it's just the active value which changes from 1 to 0. (All this reminds me of the uninstall module - deleting inactive fields - core issues: http://drupal.org/node/943772)

Almost off topic note: In my development site, the only vocabulary with the taxonomy value is in "field_tags" it remained unchanged in the database, when I went to admin/structure/taxonomy/tags/edit even and choose "Localize terms" (I tried to refresh strings).

Updated to critical, we need to fix this before a stable release.

Here the first step towards a solution, brought by you live from the i18n Sprint Camp in Berlin #di18nscb - http://i18nsprint.drupalevents.de

The attached patch for i18n_taxonomy.module assumes that:
- any term reference field should be handeled i18n_taxonomy if 18n_taxonomy.module is enabled
- any term reference field should fall back to be handeled by taxonomy if 18n_taxonomy.module is not enabled
- directly altering table {field_config} is somewhat ok

The simple approach of the attached solution is to simply swap the responsible module for every taxonomy_term_reference field from i18n_taxonomy 'back' to taxonomy when a module is disabled, and to swao taxonomy back to i18n_taxonomy as responsible module for every taxonomy_term_reference field once i18n_taxonomy.module ius enabled (again, but also for the first time -- so one side effect is that there is no longer any mix of responsibility for taxonomy_term_reference fields, but strictly either all taxonomy or all i18n_taxonomy).
This is done by simply implementing hook_disable and hook_enable and make that change to the {field_config} table directly via the database abstraction layer - which should be safe, since this table isn't handeled by any field storage engine, but is a relationally stored table which we can change using Drupals db functions ... at least in my current understanding (or is there any field api for changing module assignment for fields having been already created?).

So: please
a) confirm the validity of this approach, and
b) test and confirm the patche's integrity

cheers (and back to work on i18n sprint camp :),

daniel

new: now with field api!

Find attached a better version of above solution/patch that uses field_info_fields and field_update_field instead of directly changing db records in {field_config} to be more transarent and compatible for fieldapi and contrib modules using fieldapi hooks - big thanks to "daspeter" for the hint! (that's the cool thing about sprint camps: immediate feedback and fast learning :).

Looks good to me, only that hook can be better on the install file, right?

+++ b/i18n_taxonomy/i18n_taxonomy.moduleundefined
@@ -256,6 +256,39 @@ function i18n_taxonomy_field_info_alter(&$info) {
+ * Implements hook_enable()
+ */

Yes, these hooks belong to the .install file.

+++ b/i18n_taxonomy/i18n_taxonomy.moduleundefined
@@ -256,6 +256,39 @@ function i18n_taxonomy_field_info_alter(&$info) {
+  // from 'taxonomy' to 'i18n_taxonomy', so i18n_taxonomy.module is
+  // handling all term reference fields  ¶

Trailing spaces here :) (sorry, dreditor marks them red and bold, so I have to mention it)

Powered by Dreditor.

okay, i'll see that i move the hooks into the install file and to fix the trailing spaces (ooops).

moved to install file

Looks great, nice work everybody.

Committed, thanks.

Tip: I needed to disable and re-enable the i18n taxonomy module (after upgrading) to get this fix working.

I have an installation profile that enables i18n_taxonomy (well actually the installation profile is dependent on a feature and the feature is dependent on i18n_taxonomy).

I get this warning:
Invalid argument supplied for foreach() field.info.inc:592 [warning]

I think this is caused because the field data isn't completely built yet at this stage.