nodeorder should not show move up / down link when it does not apply

Patch works in 1.2, too (though line numbers are a little different I think, I applied it manually). Thanks ricflomag.

Any chance of getting this committed?

I like the functionality, but there are going to be too many database hits on page listings with many nodes. Here is the pseudocode for what I'd like to see in nodeorder_link():

// This goes at the beginning of the function...
static $min_weight = array();
static $max_weight = array();

// Load up the min and max weights for all tids and cache them so that we only
// have to do this once per page.
if (empty($min_weight)) {
  $result = db_query("SELECT tid, max(weight_in_tid) as max_weight, min(weight_in_tid) as min_weight FROM {term_node} group by tid");

  while ($row = db_fetch_object($result)) {
    $min_weight[$row->tid] = $row->min_weight;
    $max_weight[$row->tid] = $row->max_weight;
  }
}

/////////

// This goes where the current patch checks $minmax->min and $minmax->max

if ($node->nodeorder[$term->tid] > $min_weight[$term->tid] ) {
  // Show the move up link...
}

if ($node->nodeorder[$term->tid] < $max_weight[$term->tid] ) {
  // Show the move down link...
}

If anyone wants to take a crack at it and provide a patch that implements this, I'd get it in there.

Let's get this in there.

This has been fixed in the 6.x release