Hi, I have been having a discussion with the maintainer of Date Pop Authored (DPA) about how these two modules interact.

DPA first checks if the user has access to the "authored on" field, but since none of the modules set their weight, DPA is called first due the alphabetical order. This means that it doesn't detect the access modification made by Override Node Options (ONO).

I have tried setting the weight of ONO to a negative value, which apparently solves the problem. However, I don't know if permanently lowering the weight of ONO could have other implications. If not, would you consider lowering its weight in override_node_options.install?

CommentFileSizeAuthor
#4 override_node_options-1090696.patch825 bytesjonhattan
#3 override_node_options-1090696.patch820 bytesjonhattan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

TripleEmcoder’s picture

TripleEmcoder CreditAttribution: TripleEmcoder commented

Just as an FYI, the recent versions of these modules for 7.x seem to work together well without any tweaking.

jonhattan’s picture

jonhattan
Primary language Spanish
Location Plasencia
CreditAttribution: jonhattan commented

No, it doesn't work in D7 without tweaking module weights.

jonhattan’s picture

jonhattan
Primary language Spanish
Location Plasencia
CreditAttribution: jonhattan commented
Title: reduce module weight » Reduce module weight
Version: 6.x-1.x-dev » 7.x-1.x-dev
Status: Active » Needs review
FileSize
override_node_options-1090696.patch820 bytes
jonhattan’s picture

jonhattan
Primary language Spanish
Location Plasencia
CreditAttribution: jonhattan commented
FileSize
override_node_options-1090696.patch825 bytes

typo fixed.

rwinikates’s picture

rwinikates CreditAttribution: rwinikates commented
Status: Needs review » Reviewed & tested by the community

Applied uploaded patch and it works great. Ready for inclusion in a tagged release, if you wouldn't mind!

rwinikates’s picture

rwinikates CreditAttribution: rwinikates commented

Bump. Any of the maintainers out there? This would really be helpful.

Cauliflower’s picture

Cauliflower CreditAttribution: Cauliflower commented

Patch tested and works as expected.

opdavies’s picture

opdavies
He/him
Primary language English
Location Wales
CreditAttribution: opdavies commented
Status: Reviewed & tested by the community » Fixed

Committed to 7.x-1.x-dev. Thanks! :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

ARUN AK’s picture

ARUN AK CreditAttribution: ARUN AK commented

Hi

This same issue is happening on 6.x-1.12 branch also. I have tried the patch posted above comment. But still it is not working Please help me.

Thanks and Regards
ARUN AK

ARUN AK’s picture

ARUN AK CreditAttribution: ARUN AK commented
Category: feature » bug
Status: Closed (fixed) » Active
opdavies’s picture

opdavies
He/him
Primary language English
Location Wales
CreditAttribution: opdavies commented
Version: 7.x-1.x-dev » 6.x-1.x-dev
Assigned: Unassigned » opdavies

The above patch is for Drupal 7 so it won't work for Drupal 6.

I'll backport the change into the 6.x-1.x-dev branch.

opdavies’s picture

opdavies
He/him
Primary language English
Location Wales
CreditAttribution: opdavies commented
Status: Active » Patch (to be ported)
opdavies’s picture

opdavies
He/him
Primary language English
Location Wales
CreditAttribution: opdavies commented
Issue summary: View changes

opdavies’s picture

opdavies
He/him
Primary language English
Location Wales
CreditAttribution: opdavies commented
Status: Patch (to be ported) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

jonhattan’s picture

jonhattan
Primary language Spanish
Location Plasencia
CreditAttribution: jonhattan commented

For hte record, in Drupal 7 mdule ordering can be tweaked by implementing module_implements_alter().

opdavies’s picture

opdavies
He/him
Primary language English
Location Wales
CreditAttribution: opdavies as a volunteer commented

Whilst looking at #826522: Add permission to edit comment settings, I noticed that the change made to the weight value in this issue is preventing ONO from overriding the core comment module so the default value has been changed back to 1 rather than -1.

I think that more edge-case scenarios like the one with DPA can be resolved on an individual basis, maybe using hook_module_implements_alter() as suggested in #19.