Strict warning: Only variables should be passed by reference in fancy_login_page_alter()

I have the same error, using the theme of MAYO. Very urgent need to find a fix ... The author laid out this solution before release.

I have the same error using the Bartik default theme. Thus it does not seem theme dependent.
This message might not be seen by others if they disable php reporting of strict warnings.

what worked for me was to take this part of the fancy_login.module:

$markup = '<div id="fancy_login_dim_screen"></div>' .
			'<div id="fancy_login_login_box">' .
			'<div id="fancy_login_form_contents">' .
			'<a href="#" id="fancy_login_close_button">X</a>' .
			drupal_render(drupal_get_form('user_login')) .

and change to this:

$userLogin =drupal_get_form('user_login');
		$markup = '<div id="fancy_login_dim_screen"></div>' .
			'<div id="fancy_login_login_box">' .
			'<div id="fancy_login_form_contents">' .
			'<a href="#" id="fancy_login_close_button">X</a>' .
			drupal_render($userLogin) .

same error here

Tnx @fraguas .
This works for me.

tnx it works

FYI, Nov 2012,
I upgraded a server from freebsd8 to freebsd9
and from php 5.3 to php 5.4.7

Then I saw this issuse,
I did the above change in the module and it seems to work for us also.

So I concur if this module is ever updated, we should do consider this for the release candidate

The changes fraguas suggested in comment #4 solved the issue I was having on my site, so I thought I would roll it into a patch and put it up on this thread for review and hopefully inclusion in future versions of this module, if there are to be any.

EDIT: Ignore this patch, it is no good. Please try the patch in comment #12 in this thread.

Please disregard the patch I posted in comment #10 fails a git apply --check.

This patch passes and applies cleanly and should be the one to be used to address this error.

its work for me.. thank very very very much,,,

worked for me as well.

Could it also be that the php.ini settings are set for developmental errors? I take it this error is not found
on production servers?

works for me as well.

YES - this works perfectly

I had the same error when I moved the site from wamp to acquia dev-desk.

#4 This worked for me, thank you very much indeed!

Version 7.x-2.0 returns this whole section of code as a render array, and doesn't call render() on the form, therefore fixing this issue.

The issue causing this bug was a result of calling code like this:

'#markup' => drupal_render(drupal_get_form('user_login')),

The problem here is that drupal_render() expects a variable to be passed to it, that it can then alter directly. I was passing it the result of a function, drupal_get_form(). PHP with strict enforcement doesn't like this (rightfully so).

It is a non-issue now however, as everything is done with render arrays in the new version, and nothing is actually rendered in this function, removing the issue altogether.