Closed (duplicate)
Project:
Automated Logout
Version:
6.x-4.x-dev
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
15 Mar 2011 at 16:46 UTC
Updated:
29 Aug 2012 at 15:16 UTC
Jump to comment: Most recent file
Comments
Comment #1
yodersj commentedI'm confirming that removing commas at end of lines 52 and 65 fixed the javascript errors I was seeing in IE 7 with the latest v6.x-4.x-dev (2011-Feb-25). No apparent side affects in Firefox 3.6.15.
Comment #2
ken hawkins commentedBumping up to R&T to draw attention -- and it's a pretty straightforward fix.
Comment #3
Equinger commentedI really appreciate this module and hope to see this branch maintained so that I can use it! As of now, due to problems that myself and others have posted (and apparently fixed), including this one, this branch is not yet usable. I would definitely help if I had the facility to do so.
Comment #4
tayzlor commentedHere is a patch to cover this.
I've also added an additional piece of code that checks if the user is actually active in the page (moving their mouse around, clicking on form elements etc...) before setting the timeout period.
Previously, the timeout period would be at all times until the user clicked on a link to refresh the page again.
Comment #5
tayzlor commentedComment #6
kevin.dutra commented@tayzlor You should probably open up a separate (feature request) issue for the page activity thing--it doesn't relate to the commas breaking it for IE. If I could offer some constructive criticism for that portion of your patch: I think some further thought probably needs to be done. While it may successfully delay the dialog box from appearing, it's not affecting the PHP session on the server side, so the next link clicked is still going to result in denied access.
At any rate, I'm attaching a patch that only has the fix for the commas. This branch seems a bit abandoned, but I hope that this will make it in.
Comment #7
drudrew commentedIt would be great if this patch makes it to the next release.
Comment #8
kevin.dutra commentedLooks like this is taken care of with #1056214: IE7 Error: Expected identifier, string or number