In autologout.js there are a couple unneeded commas -- one at the end of line 52 and the other at the end of line 65.

These break the JS (and overall execution of aggregated code) in IE 7 and 6.

Comments

yodersj’s picture

I'm confirming that removing commas at end of lines 52 and 65 fixed the javascript errors I was seeing in IE 7 with the latest v6.x-4.x-dev (2011-Feb-25). No apparent side affects in Firefox 3.6.15.

ken hawkins’s picture

Status: Needs review » Reviewed & tested by the community

Bumping up to R&T to draw attention -- and it's a pretty straightforward fix.

Equinger’s picture

I really appreciate this module and hope to see this branch maintained so that I can use it! As of now, due to problems that myself and others have posted (and apparently fixed), including this one, this branch is not yet usable. I would definitely help if I had the facility to do so.

tayzlor’s picture

StatusFileSize
new985 bytes

Here is a patch to cover this.
I've also added an additional piece of code that checks if the user is actually active in the page (moving their mouse around, clicking on form elements etc...) before setting the timeout period.

Previously, the timeout period would be at all times until the user clicked on a link to refresh the page again.

tayzlor’s picture

Status: Reviewed & tested by the community » Needs review
kevin.dutra’s picture

StatusFileSize
new630 bytes

@tayzlor You should probably open up a separate (feature request) issue for the page activity thing--it doesn't relate to the commas breaking it for IE. If I could offer some constructive criticism for that portion of your patch: I think some further thought probably needs to be done. While it may successfully delay the dialog box from appearing, it's not affecting the PHP session on the server side, so the next link clicked is still going to result in denied access.

At any rate, I'm attaching a patch that only has the fix for the commas. This branch seems a bit abandoned, but I hope that this will make it in.

drudrew’s picture

It would be great if this patch makes it to the next release.

kevin.dutra’s picture

Status: Needs review » Closed (duplicate)