The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.I have used img_assist for quite a while, and find it very useful. I just upgraded to 4.7.5 (from 4.7.3) and decided to start with clean version of all modules. I just noticed that when img_assist pulls the image, the img src="http://mysite.com/system/files/img.jpg" rather than "/files/img.jpg", in otherwords, it is a full url rather than a url relative to the drupal base. I don't recall this being the case in the past and would like to change this back. Since I imagine there was a reason for this change (which I would love to hear about since perhaps I am missing something important), I am happy to override this in template.php rather than the module itself, but I am not sure the function that is called, and how the src is being defined. I went through the module, but my php is poor and I am not quite sure when it is that the base_path is being printed and used as src, or when it is being used as a reference for the module.
Any help would be very appreciated.
Thanks,
Maria
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | img_assist.abs2rel.patch | 1.45 KB | sun |
Comments
Comment #1
mariagwyn commentedsorry, forgot this: img_assist.module,v 1.56.2.18 2006/12/14
-m
Comment #2
themselves commentedI'm discovering this for the first time as well, and it's a big hassle - I have a dev, staging and live server, all 3 of which have different URLs. Has anyone had a look at this issue?
Comment #3
mariagwyn commentedI have upgraded from 4.7 to 5.1, and am using Image Assist 5.x-1.1. The code is still placing the image into the node with the full url (http://sitename.com/system/files/image.img). This is a MAJOR PROBLEM since I often build on development sites and then move to a live site. Every image that is put in a node via image assist then has the wrong 'http://sitename.com' in it. Can someone offer a suggestion, or a php snippet that will strip this function from image assist? I have been trying to think of scenarios where it would be crucial to have the full url inserted into the html of the page, but I can't think why it would ever be better than a relative url that utilizes drupal's administrator-set filepath.
Help? Please?
Maria
Comment #4
wessex commentedYikes. I'm building a site on a test domain and this will be a major problem when it moves...
Comment #5
benshell commentedThis won't be a problem when you move your sites as long as you're using the img_assist filter tag (and not inserting HTML code). Just clear your cache tables after you move your sites. The 'devel' module makes this really easy.
RSS feeds and "email this page" features are two reasons that absolute URLs for images are necessary. This really should be an option though, since I understand that not everyone needs or wants absolute URLs.
Comment #6
jaredwiltshire commentedThis needs to be fixed.
Related issues (I think):
http://drupal.org/node/153844
http://drupal.org/node/113875
Comment #7
sunEither way, let's reword it and call it a bug. Most of our internal development sites are served through internal network and internet simultaneously. Images are only displayed on the url, on which a node update was invoked last.
Cached paths definitely should be relative.
Attached patch fixes this issue by removing calls to file_create_url(). I wasn't able to test private file download method.
Comment #8
sunComment #9
(not verified) commented