Add support for a transliteration text format filter.

This looks like a nice addition, still need some time to test. Could you please change all function names to use transliteration_filter_*() instead of _filter_transliteration_*()?

 filter_transliteration/README.html                 |    3 +
 filter_transliteration/README.markdown             |    9 +++
 filter_transliteration/README.txt                  |   13 ++++

Do we really need three README files?

+++ b/filter_transliteration/README.txt
@@ -0,0 +1,13 @@
+                           [1]Filter transliteration
+
+   Provides a [2]text format input filter for the [3]Transliteration
+   module.
+
+   Also available as a [4]patch.
+
+References
+
+   1. http://drupal.org/project/filter_transliteration

References a different project.

+++ b/filter_transliteration/filter_transliteration.module
@@ -0,0 +1,61 @@
+      'process callback' => '_filter_transliteration_process',
+      'settings callback' => '_filter_transliteration_settings',
+      'tips callback' => 'filter_transliteration_tips',

Inconsistent naming for filter_transliteration_tips.

+++ b/filter_transliteration/filter_transliteration.module
@@ -0,0 +1,61 @@
+ * Implements hook_filter_FILTER_process().
+ * @see filter_transliteration_filter_info()
...
+ * Implements hook_filter_FILTER_settings().
+ * @see filter_transliteration_filter_info()
...
+ * Implements hook_filter_FILTER_tips().
+ * @see filter_transliteration_filter_info()

Needs a blank line before @see.

The Drupal standard is to include a README.txt, so let's go with that one :)

Looks good to me now. I think those @see's are not really needed anyway because they're referencing a function in the same file (and it's a really small file :)). Anyway, don't re-roll just for this change, they can be easily handled at commit-time.

--- /dev/null
+++ b/filter_transliteration/filter_transliteration.info

Hm. There's a module namespace issue here.

Normally, this should be transliteration_filter, but of course, that leads to rather wonky function names like transliteration_filter_filter_info()...

Is there actually any reason for making this a separate sub-module?

Looks like these 50 lines could as well live in the .module?

+++ b/filter_transliteration/filter_transliteration.module
@@ -0,0 +1,64 @@
+ *
+ * @see http://drupal.org/project/transliteration

Can be removed.

+++ b/filter_transliteration/filter_transliteration.module
@@ -0,0 +1,64 @@
+      'title' => t('Transliteration'),
+      'description' => t('Convert non-latin text to US-ASCII equivalents.'),

The description is the title.

Leave the description empty, if there's nothing to describe.

+++ b/filter_transliteration/filter_transliteration.module
@@ -0,0 +1,64 @@
+      'default settings' => array('unknown' => '?'),
...
+  $filter->settings += $defaults;
...
+    'unknown' => array(
...
+      '#title' => t('Unknown'),
...
+      '#default_value' => $filter->settings['unknown'],

Uhm, this needs work. ;)

+++ b/filter_transliteration/filter_transliteration.module
@@ -0,0 +1,64 @@
+ *
+ * @see filter_transliteration_filter_info()
...
+ *
+ * @see filter_transliteration_filter_info()
...
+ *
+ * @see filter_transliteration_filter_info()

Can be removed.

+++ b/filter_transliteration/filter_transliteration.module
@@ -0,0 +1,64 @@
+      '#field_prefix' => t('Replace non-ASCII characters with') . ' ',
+      '#field_suffix' => ' ' . t('if there is no suitable ASCII equivalent.'),

The additional spaces before and after the field can be removed.

+++ b/filter_transliteration/filter_transliteration.module
@@ -0,0 +1,64 @@
+      '#maxlength' => 5,

Why 5?

+++ b/filter_transliteration/filter_transliteration.module
@@ -0,0 +1,64 @@
+      '#attributes' => array('style' => 'width: 1em'),

Should be removed.

+++ b/filter_transliteration/filter_transliteration.module
@@ -0,0 +1,64 @@
+  return t('Non-latin text will be converted to US-ASCII equivalents.');

I don't think that ordinary end-users are going to understand what this means.

@pillarsdotnet, you forgot about this part:

Is there actually any reason for making this a separate sub-module?

Looks like these 50 lines could as well live in the .module?

Let's move the filter to transliteration.module :)

Pasting @sun's comments from IRC:

1. don't think we want a separate module?
2. you misunderstood the request to replace title with description, the current filter label (visible in admin UI) is nonsense for humans
3. the filter setting key is still not self-descriptive
4. don't understand the += $defaults (not needed in D7)
5. #title should be visible
6. #field_prefix/suffix most likely look strange
7. filter tip sounds wonky

I actually think "Non-latin text will be converted to US-ASCII equivalents." works fine, perhaps just some examples need embedding? (E.g., "Non-latin text (e.g., å, ö, 漢) ... US-ASCII equivalents (a, o, ?)." I don't think we should remove the technical terms just because they're technical. People can either use the examples to guide them or look up the terms they're unsure of.

Or better yet, close the issue as "won't fix" and I will continue to maintain the separate Filter transliteration module.

Whether the code is living in Transliteration or in your own module, the code (incl. wording) comments are just as valid.

Cleaned-up a bit the patches from #26 and committed to 6.x-3.x and 7.x-3.x. I decided to include this functionality in the main module though.

Thanks for all the work on this, Bob :)

http://drupalcode.org/project/transliteration.git/commit/ee9b55e
http://drupalcode.org/project/transliteration.git/commit/6a53653