Upgrade OG Forum to 5.x

subscribing

Attached is a patch to port og_forum to Drupal 5.x. It's working fine for me, but can't guarantee it's totally error-free.

I've taken this patch and attempted to merge it with the multiple forums per group patch ( http://drupal.org/node/68295 ), however it only seems to be partially working. When you click on the manage group forum link and then attempt to add or edit a forum, I'm receiving a page not found error. I am a hacker at best when it comes to modules, but I'm going to throw what I have done out there if anyone else wants to take a swing at getting it up and running. I think many people need the multiple forum functionality.

NOTE: Just Rename the attached file to og_forum.module

Thanks,

Josh

afaict, these are seperate issues.

Yes, I would agree these are separate issues, but I figured I would just throw it out there. In retrospect, it probably wasn't a good idea.

Thanks,

Josh

Joshua - this probably should be a separate issue, can you file a patch based on the updated module you submitted?

Also, did my original patch for porting to 5.x work for you? I don't really want to be attempting to fix two issues with one patch, so it'd be great if we could get my patch released before I start looking at yours.

I notice the project page states this module is abandoned, I'd be willing to take it over if it means we can get a 5.x release made.

I would say yes, your patch did work for me with 5.1. That was the reason I moved forward with it and added the multiple forum functionality. You are correct though, your patch should be more thoroughly tested first and once it is deemed acceptable we can worry about adding the multiple forum patch. It's a key addition to my website, that's the reasoning for moving ahead perhaps too quickly.

Just an FYI, it appears to me the module I submitted does not work properly as the way forms are created has changed in 5.x I will continue to try to get it working.

Thanks,

Josh

Since Joshua_cohen reports my patch as working I'm changing this to ready to be committed, and future work for multi-forum support should be filed as a separate issue.

And yes, form handling did change in 5.x so that needs changing - however, I can't remember ever that causing a page not found error.

The original patch was working, but there was a little more cleanup to do.

Missed a few lines.

Fixed in CVS commit 57508.

I put several patches together and added more. As I was working with an earlier post of this patch, I'll check my code. Thanks.

see http://drupal.org/node/121822

for my contribution.