Updated to 5.x, now compatible with regular forums & more

I made a release for Drupal 5 yesterday. It sounds like you may have fixed some things better than I did, but please check. Please open a separate new issue for each problem you find.

It's too difficult to figure out what changes fix what issues when you lump them all together. Please specify the changes you are suggesting for each issue you opened or learn how to make patches.

rconstantine,

Thank you for your hard work on this module! I have not tested yet, but your improvements sound great.

Thanks,

Josh

I'd like to thank you as well, i am testing as much as i can, and I have only found one error so far. When i try to create the forums for groups allready made, it will not make them.

Thanks alot.
Rasmus.

I would appreciate more help testing the official version now that we have one.

Does the official version have all of rconstantine's changes applied?

Thanks,

Josh

He mixed too many changes together for me to be sure, but it addresses all the issues that have been reported.

Hi RCconstantine.

Yes that was the button i referred to.
It does not create forums for existing groups on my site.

It just says:
0 groups had forums created
The settings has been applied.

I know many of you may have the same experience as mine that when you play MMO games, you got yourselves beat up by some bad guys. You wanna fight them back. But their levels are much higher than you, or they’ve got much better weapon and equipment. So what should you do? Go to www.gamegoldrush.com then you are gonna find a way to kick their ass back. Do whatever you wanna do, and be the person you always wanna be, is the most exciting part of games. I hope you guys all have fun with your game playing, just like what I am doing right now.

Resetting properties.

I must have messed up the items in og_term and term_data. I removed everything in og_term, and the respective data in term_data. I then tried again and everything worked fine

Thanks for the help so far ;)

There is a problem with this patch. After a form topic is created, if you edit the post it will make it orphan. Meaning, it will not list in the group form anymore, not sure where it goes!!!

If I set the context in forum module that fixes it. For now, I am using 5.x-1.3 with my hack to core forum module.

I took the one at your message #8. Every thing works fine until the forum topic is edited. Once it is edited, it looks like it doesnt care about forum context. It is strange it is happenning to me only. For now I've taken the main version and hacked the core forum module for context/theme issue as that seems to be the only problem with the main version -- 5.x-1.3. Thanks.

I reduced the patch to its essential differences from the official version. I will split it into separate issues later if no one else does. I can't commit the whole thing at once because the official code is working and problems are still being reported with this patch. Changes to the official version will be made one piece at a time, so if something breaks we'll know why. I'm setting this issue as fixed because we have an official Drupal 5 version that works with regular forums.

Forgot to attach the simplified patch.

Regular forums used to disappear completely when og_forums was enabled. That's why I say the official version now works with regular forums. I would be happy to see coherent feature requests with patches showing exactly what needs to be changed to achieve the following features:

1. Hiding group forums from non-members. At the moment, access to individual topics is restricted but access to the forums is not.
2. Only displaying forums for the current group in the forum selection list.

I turned two existing issues into the needed feature requests. If no one else does so, I will tease out the parts of Ryan's patch that apply to each issue.

Ryan, I'm sure your patch will end up saving me a lot of time. It just takes longer to get around to seeing what a big patch does. I applied a number of smaller patches to create the official releases, and I need to make sure they don't conflict. The purpose of the unreleased version in CVS was to reduce the number of non-essential differences between your code and the official version.

subscribing.

I’ve been trying alot now to get og_forum to work properly, but had no luck.

It seems to work correct when I am logged in as admin/user1.

But when I log in as a normal user. And try to see the forum in a group the user is member of.
It just says “Select a forum below” and then it doesn’t show “general discussion” which it should.
I don’t see the group forum under the regular forum, like I do as an admin (there I see all group forums)

Now I see the issue when adding a forum post by using “add content” too, so can you guys maybe tell me how I remove the option to make a forum post under “add content”?

Thank you
Rasmus Porsager.

forgot to change status.

Please, this issue is closed. See if there are similar open issues or create one yourself.

rconstantine kindly assigned some portions of his patch in two separate issues. The remaining portions have not yet been assigned to any issue.

I tried out the patches as given in this thread and it didn't work for me. Some code review made me aware of the function og_forum_db_rewrite_sql, where the filtering of forums should take place. This is the code fragment I found

$return['where'] = 't.tid NOT IN (
SELECT x . tid FROM (
SELECT ogt.tid FROM {og_term} ogt
INNER JOIN {og_uid} ogu
ON ogt.nid = ogu.nid AND ogu.uid != 1
) x
WHERE x.tid NOT IN (
SELECT ogt.tid FROM {og_term} ogt
INNER JOIN {og_uid} ogu
ON ogt.nid = ogu.nid AND ogu.uid = 2
)
)
AND t.tid NOT IN (
SELECT ogt.tid FROM {og_term} ogt
INNER JOIN {og_uid} ogu
ON ogt.nid = ogu.nid AND ogu.uid = 2
WHERE ogu.is_active = 0
)';
if ($restrict2) {
$og_nid = og_forum_gid_from_tid(arg(3));

if ($og_nid && !$og_vocab) {
$og_vocab = TRUE;
//Same as above, except without removing is_active == 0 forums since we are looking for a particular node.
//Need to put the join in here since we need to match ogt.nid
$return['join'] = "LEFT JOIN {og_term} ogt ON $primary_table.tid = ogt.tid";
$return['where'] = "t.tid NOT IN (
SELECT x.tid FROM(
SELECT ogt.tid FROM {og_term} ogt
INNER JOIN {og_uid} ogu
ON ogt.nid = ogu.nid AND ogu.uid != 1
) x
WHERE x.tid NOT IN (
SELECT ogt.tid FROM {og_term} ogt
INNER JOIN {og_uid} ogu
ON ogt.nid = ogu.nid AND ogu.uid = 2
)
)
AND ogt.nid = $og_nid";
}
}

The ogu.uid = 2 seemed strange to me, so I changed that to $user->uid and it now seems to work for me.

$return['where'] = 't.tid NOT IN (
SELECT x . tid FROM (
SELECT ogt.tid FROM {og_term} ogt
INNER JOIN {og_uid} ogu
ON ogt.nid = ogu.nid AND ogu.uid != 1
) x
WHERE x.tid NOT IN (
SELECT ogt.tid FROM {og_term} ogt
INNER JOIN {og_uid} ogu
ON ogt.nid = ogu.nid AND ogu.uid = ' . $user->uid . '
)
)
AND t.tid NOT IN (
SELECT ogt.tid FROM {og_term} ogt
INNER JOIN {og_uid} ogu
ON ogt.nid = ogu.nid AND ogu.uid = '. $user->uid . '
WHERE ogu.is_active = 0
)';
if ($restrict2) {
$og_nid = og_forum_gid_from_tid(arg(3));

if ($og_nid && !$og_vocab) {
$og_vocab = TRUE;
//Same as above, except without removing is_active == 0 forums since we are looking for a particular node.
//Need to put the join in here since we need to match ogt.nid
$return['join'] = "LEFT JOIN {og_term} ogt ON $primary_table.tid = ogt.tid";
$return['where'] = "t.tid NOT IN (
SELECT x.tid FROM(
SELECT ogt.tid FROM {og_term} ogt
INNER JOIN {og_uid} ogu
ON ogt.nid = ogu.nid AND ogu.uid != 1
) x
WHERE x.tid NOT IN (
SELECT ogt.tid FROM {og_term} ogt
INNER JOIN {og_uid} ogu
ON ogt.nid = ogu.nid AND ogu.uid = ' . $user->uid . '
)
)
AND ogt.nid = $og_nid";
}
}

I tried out the patches as given in this thread and it didn't work for me. Some code review made me aware of the function og_forum_db_rewrite_sql, where the filtering of forums should take place. This is the code fragment I found

$return['where'] = 't.tid NOT IN (
SELECT x . tid FROM (
SELECT ogt.tid FROM {og_term} ogt
INNER JOIN {og_uid} ogu
ON ogt.nid = ogu.nid AND ogu.uid != 1
) x
WHERE x.tid NOT IN (
SELECT ogt.tid FROM {og_term} ogt
INNER JOIN {og_uid} ogu
ON ogt.nid = ogu.nid AND ogu.uid = 2
)
)
AND t.tid NOT IN (
SELECT ogt.tid FROM {og_term} ogt
INNER JOIN {og_uid} ogu
ON ogt.nid = ogu.nid AND ogu.uid = 2
WHERE ogu.is_active = 0
)';
if ($restrict2) {
$og_nid = og_forum_gid_from_tid(arg(3));

if ($og_nid && !$og_vocab) {
$og_vocab = TRUE;
//Same as above, except without removing is_active == 0 forums since we are looking for a particular node.
//Need to put the join in here since we need to match ogt.nid
$return['join'] = "LEFT JOIN {og_term} ogt ON $primary_table.tid = ogt.tid";
$return['where'] = "t.tid NOT IN (
SELECT x.tid FROM(
SELECT ogt.tid FROM {og_term} ogt
INNER JOIN {og_uid} ogu
ON ogt.nid = ogu.nid AND ogu.uid != 1
) x
WHERE x.tid NOT IN (
SELECT ogt.tid FROM {og_term} ogt
INNER JOIN {og_uid} ogu
ON ogt.nid = ogu.nid AND ogu.uid = 2
)
)
AND ogt.nid = $og_nid";
}
}

The ogu.uid = 2 seemed strange to me, so I changed that to $user->uid and it now seems to work for me.

$return['where'] = 't.tid NOT IN (
SELECT x . tid FROM (
SELECT ogt.tid FROM {og_term} ogt
INNER JOIN {og_uid} ogu
ON ogt.nid = ogu.nid AND ogu.uid != 1
) x
WHERE x.tid NOT IN (
SELECT ogt.tid FROM {og_term} ogt
INNER JOIN {og_uid} ogu
ON ogt.nid = ogu.nid AND ogu.uid = ' . $user->uid . '
)
)
AND t.tid NOT IN (
SELECT ogt.tid FROM {og_term} ogt
INNER JOIN {og_uid} ogu
ON ogt.nid = ogu.nid AND ogu.uid = '. $user->uid . '
WHERE ogu.is_active = 0
)';
if ($restrict2) {
$og_nid = og_forum_gid_from_tid(arg(3));

if ($og_nid && !$og_vocab) {
$og_vocab = TRUE;
//Same as above, except without removing is_active == 0 forums since we are looking for a particular node.
//Need to put the join in here since we need to match ogt.nid
$return['join'] = "LEFT JOIN {og_term} ogt ON $primary_table.tid = ogt.tid";
$return['where'] = "t.tid NOT IN (
SELECT x.tid FROM(
SELECT ogt.tid FROM {og_term} ogt
INNER JOIN {og_uid} ogu
ON ogt.nid = ogu.nid AND ogu.uid != 1
) x
WHERE x.tid NOT IN (
SELECT ogt.tid FROM {og_term} ogt
INNER JOIN {og_uid} ogu
ON ogt.nid = ogu.nid AND ogu.uid = ' . $user->uid . '
)
)
AND ogt.nid = $og_nid";
}
}

I tried out the patches as given in this thread and it didn't work for me. Some code review made me aware of the function og_forum_db_rewrite_sql, where the filtering of forums should take place. This is the code fragment I found

$return['where'] = 't.tid NOT IN (
SELECT x . tid FROM (
SELECT ogt.tid FROM {og_term} ogt
INNER JOIN {og_uid} ogu
ON ogt.nid = ogu.nid AND ogu.uid != 1
) x
WHERE x.tid NOT IN (
SELECT ogt.tid FROM {og_term} ogt
INNER JOIN {og_uid} ogu
ON ogt.nid = ogu.nid AND ogu.uid = 2
)
)
AND t.tid NOT IN (
SELECT ogt.tid FROM {og_term} ogt
INNER JOIN {og_uid} ogu
ON ogt.nid = ogu.nid AND ogu.uid = 2
WHERE ogu.is_active = 0
)';
if ($restrict2) {
$og_nid = og_forum_gid_from_tid(arg(3));

if ($og_nid && !$og_vocab) {
$og_vocab = TRUE;
//Same as above, except without removing is_active == 0 forums since we are looking for a particular node.
//Need to put the join in here since we need to match ogt.nid
$return['join'] = "LEFT JOIN {og_term} ogt ON $primary_table.tid = ogt.tid";
$return['where'] = "t.tid NOT IN (
SELECT x.tid FROM(
SELECT ogt.tid FROM {og_term} ogt
INNER JOIN {og_uid} ogu
ON ogt.nid = ogu.nid AND ogu.uid != 1
) x
WHERE x.tid NOT IN (
SELECT ogt.tid FROM {og_term} ogt
INNER JOIN {og_uid} ogu
ON ogt.nid = ogu.nid AND ogu.uid = 2
)
)
AND ogt.nid = $og_nid";
}
}

The ogu.uid = 2 seemed strange to me, so I changed that to $user->uid and it now seems to work for me.

$return['where'] = 't.tid NOT IN (
SELECT x . tid FROM (
SELECT ogt.tid FROM {og_term} ogt
INNER JOIN {og_uid} ogu
ON ogt.nid = ogu.nid AND ogu.uid != 1
) x
WHERE x.tid NOT IN (
SELECT ogt.tid FROM {og_term} ogt
INNER JOIN {og_uid} ogu
ON ogt.nid = ogu.nid AND ogu.uid = ' . $user->uid . '
)
)
AND t.tid NOT IN (
SELECT ogt.tid FROM {og_term} ogt
INNER JOIN {og_uid} ogu
ON ogt.nid = ogu.nid AND ogu.uid = '. $user->uid . '
WHERE ogu.is_active = 0
)';
if ($restrict2) {
$og_nid = og_forum_gid_from_tid(arg(3));

if ($og_nid && !$og_vocab) {
$og_vocab = TRUE;
//Same as above, except without removing is_active == 0 forums since we are looking for a particular node.
//Need to put the join in here since we need to match ogt.nid
$return['join'] = "LEFT JOIN {og_term} ogt ON $primary_table.tid = ogt.tid";
$return['where'] = "t.tid NOT IN (
SELECT x.tid FROM(
SELECT ogt.tid FROM {og_term} ogt
INNER JOIN {og_uid} ogu
ON ogt.nid = ogu.nid AND ogu.uid != 1
) x
WHERE x.tid NOT IN (
SELECT ogt.tid FROM {og_term} ogt
INNER JOIN {og_uid} ogu
ON ogt.nid = ogu.nid AND ogu.uid = ' . $user->uid . '
)
)
AND ogt.nid = $og_nid";
}
}

Excuse me for the three posts. One would have sufficed, the server was very unresponsive. I can't remove my own comments, otherwise I would have done so.