Closed (fixed)
Project:
Services
Version:
6.x-3.x-dev
Component:
User interface
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
17 Mar 2011 at 16:54 UTC
Updated:
18 May 2011 at 18:51 UTC
Jump to comment: Most recent file
Comments
Comment #1
kylebrowning commentedComment #2
kylebrowning commentedWoops
Comment #3
kylebrowning commentedIm not sure how to remove the trailing whitepsace warnings. :(
Comment #4
ygerasimov commentedHere is patch that can be applied after http://drupal.org/node/855392#comment-4232904 that fixes whitespaces plus:
- fixes code styling problems
- some refactoring
- add validation on resources form (I can't get proper highligting of wrong alias field)
Please review.
Comment #5
kylebrowning commentedMy name is Kyle Browning, and I approve this patch!
Comment #6
kylebrowning commentedUpdated patched for current 7.x-3.x branch
Comment #7
marcingy commentedFirst pass review
Can we look to use #attach rather than drupal_add_css and drupal_add_js as this is the norm in d7.
I'm sure there are some other bits and pieces but this is first thing that springs out at me.
Leaving at needs review so as you get additional comments.
I'll do a second pass when I'm more awake tomorrow.
Comment #8
kylebrowning commentedUpdated patch for marcingy's comments
Comment #9
marcingy commentedFew minor things (sorry)
* in services_edit_form_endpoint_resources instead of calling drupal_get_path twice assign the value to a variable ie
Can this be reworked
to be something along these line, ie we only do one if comparision?
We have some formatting issue here
should be
There are similar issue further down in services_edit_form_endpoint_resources and else if should be elseif
There are 2 full stops on this line
Comment #10
kylebrowning commentedUpdated patch.
Comment #11
kylebrowning commentedwoops
Comment #12
kylebrowning commentedUpdated patch
Comment #13
ygerasimov commentedPatch #12 introduces some trailing spaces. I have removed them.
Comment #14
marcingy commentedComment #15
kylebrowning commentedComment #16
kylebrowning commented