Comments

dawehner’s picture

Category: feature » task

This is a valuable task

manuel garcia’s picture

Assigned: Unassigned » manuel garcia
Status: Active » Needs review
StatusFileSize
new4.06 KB

Here's a working patch against 6.x-3.x

Enabling views:
drush views-enable frontpage
drush ven frontpage taxonomy_term

Disabling views:
drush views-disable frontpage
drush vdis frontpage taxonomy_term

dawehner’s picture

Status: Needs review » Needs work

I'm sorry but this patch does not apply anymore, because recently a views analyze command was added.

In general the code looks fine but in d7 we could perhaps use some ctools functions to enable/disable a view. There is one

chx’s picture

A quick grep makes me think views_defaults is gone and testModuleTemplates fails as well.

dawehner’s picture

@chx
Was this comment related to this issue?
In general there is already an issue about testModuleTemplates.

chx’s picture

The patch runs + variable_set('views_defaults', $views_status); and so my comment was meant for this issue -- but it's only gone in 7.x sorry i confused my trees :)

dawehner’s picture

Oh i recognized this as well: http://drupal.org/node/1096652#comment-4684470 ... facepalm ...

manuel garcia’s picture

Status: Needs work » Needs review
StatusFileSize
new3.61 KB

Here's an updated patch, should apply fine against 6.x-3.x

was too lazy to use format-patch though ... :X

merlinofchaos’s picture

delimited is misspelled.

manuel garcia’s picture

StatusFileSize
new3.61 KB

Very true, misspelled differently in 4 places...

Here's an updated patch.

dawehner’s picture

Status: Needs review » Fixed

Oh i missed to see the patch

Did some manual testing and it worked fine.

The review also passed so commited to 6.x-3.x and 7.x-3.x.
Thanks!! for working on that, i really like it.

andypost’s picture

Version: 6.x-3.x-dev » 7.x-3.x-dev
Status: Fixed » Reviewed & tested by the community
StatusFileSize
new472 bytes

Example for disable is wrong

dawehner’s picture

Status: Reviewed & tested by the community » Fixed

Thanks!

manuel garcia’s picture

awesome!

oops! @andypost good catch!

Status: Fixed » Closed (fixed)
Issue tags: -drush

Automatically closed -- issue fixed for 2 weeks with no activity.