Posted by riccardoR on January 16, 2007 at 2:08am
| Project: | Taxonomy Block |
| Version: | master |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
Patch attached to update HEAD to drupal 5.
A new branch would be very useful. :-)
WARNING: do not use this patch in a production site (it is my first module update: I needed it and gave it a try).
I tested the patch on a development site, running the just released Drupal 5.0 (wonderful!), and it seems to be working smoothly.
NOTE: I added a clear_cache_all() in taxonomy_block_delete_form_submit() (at line 220 of taxonomy_block.module).
I think it is good to clear the page cache whenever a taxonomy block is deleted, but I am not 100% sure it is really needed.
Please review with care.
| Attachment | Size |
|---|---|
| taxonomy_block_to5.patch | 6.03 KB |
Comments
#1
i marked http://drupal.org/node/99167 as a duplicate of this.
#2
Okay, I've committed the .info file and a hook_uninstall implementation. I used your patch as a starting place and then did some big revisions to put the add, edit, delete and view functions on their own form/pages. It looks good to me but I'd like to have some testers before I commit it.
#3
okay, i've fixed one bug and added some help text to this patch and committed it.
riccardoR, thanks for your help!
#4
Excellent work Drewish.
Thank you very much!
#5
#6
Hi,
I saw this patch, but the taxonomy_block.module doesnt have a drupal 5 version yet?
Is it committed to head, so the latest taxonomy_block module is the drupal 5 version?
If not, can somebody post the taxonomy_block.module drupal 5 version without bugs as committed?
thanks in advance!
greetings,
Martijn
#7
I saw the HEAD version works for Drupal 5.
Please make a Drupal 5 version, so other people know exactly that the module is updated. If I am wrong off course, sorry for these lines...
Greetings,
Martijn
#8
you'll have to be patient. i posted a release but it hasn't been published yet. http://drupal.org/node/148592
#9
Hi,
I still like this module for some blocks over the views-layout. But advertisement-nodetype (www.drupal.org/project/ad), and other not core content-types do not work with this 5-update.
Also images are not shown.
Is it possible still to update the module, so all installed contenttypes will be shown (tagged with the taxonomy term) and images are shown in the block?
Thanks a lot in advance if you consider this!
Greetings,
Martijn