Patch attached to update HEAD to drupal 5.
A new branch would be very useful. :-)

WARNING: do not use this patch in a production site (it is my first module update: I needed it and gave it a try).
I tested the patch on a development site, running the just released Drupal 5.0 (wonderful!), and it seems to be working smoothly.

NOTE: I added a clear_cache_all() in taxonomy_block_delete_form_submit() (at line 220 of taxonomy_block.module).
I think it is good to clear the page cache whenever a taxonomy block is deleted, but I am not 100% sure it is really needed.

Please review with care.

CommentFileSizeAuthor
#2 taxonomy_block.module.patch9.13 KBdrewish
taxonomy_block_to5.patch6.03 KBriccardoR

Comments

drewish’s picture

drewish commented

i marked http://drupal.org/node/99167 as a duplicate of this.

drewish’s picture

drewish commented
StatusFileSize
new taxonomy_block.module.patch9.13 KB

Okay, I've committed the .info file and a hook_uninstall implementation. I used your patch as a starting place and then did some big revisions to put the add, edit, delete and view functions on their own form/pages. It looks good to me but I'd like to have some testers before I commit it.

drewish’s picture

drewish commented
Status: Needs review » Fixed

okay, i've fixed one bug and added some help text to this patch and committed it.

riccardoR, thanks for your help!

riccardoR’s picture

riccardoR commented

Excellent work Drewish.
Thank you very much!

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)
summit’s picture

summit commented
Title: Update to drupal 5 » taxonomy Block Update to drupal 5

Hi,

I saw this patch, but the taxonomy_block.module doesnt have a drupal 5 version yet?
Is it committed to head, so the latest taxonomy_block module is the drupal 5 version?
If not, can somebody post the taxonomy_block.module drupal 5 version without bugs as committed?

thanks in advance!
greetings,
Martijn

summit’s picture

summit commented

I saw the HEAD version works for Drupal 5.
Please make a Drupal 5 version, so other people know exactly that the module is updated. If I am wrong off course, sorry for these lines...

Greetings,
Martijn

drewish’s picture

drewish commented

you'll have to be patient. i posted a release but it hasn't been published yet. http://drupal.org/node/148592

summit’s picture

summit commented
Category: feature » bug

Hi,

I still like this module for some blocks over the views-layout. But advertisement-nodetype (www.drupal.org/project/ad), and other not core content-types do not work with this 5-update.
Also images are not shown.

Is it possible still to update the module, so all installed contenttypes will be shown (tagged with the taxonomy term) and images are shown in the block?

Thanks a lot in advance if you consider this!

Greetings,
Martijn