Clean up Views 3 UI for Stark theme

However, if we clean it up in Stark first, there will be better defaults for both Seven/Bartik, and other contrib admin themes.

+1000

My +1000 got eaten somehow.

Views 3 on Rubik is kaput.

sub.

Here is an initial patch fixing most of the problems when adding a view (before editing).

Still needs a lot of work.

subscribe

In the changes to views-admin.ctools.css, I don't see why the !importants are necessary:

.ctools-content ul {
  margin: 0 !important;
  padding: 0 !important;
}

Can you provide an example where there's a style the won't be overridden without them?

That line affects the new links menu on admin/structure/views. The ones with edit, disable, clone and export.

But you're right, it can be done in another way.

Here is the patch that fixes that.

Here is a working patch that fixes all evident issues. This need some testing with other themes and specially test it to check if nothing got broken with Seven.

use this patch since the previous one broke some things in seven.

Ltest update (prior and after these patches) leaves the Views edit UI themeless and empty, even using Seven.

Correction: It appears this happens ONLY some custom made views, not default ones.

That's weird. This is just pure CSS, if it looks like that is because some files are not loading.

I enabled Rubik and Tao from git and I'm getting tons of errors, I can't fix this if Tao/Rubik are not working properly.

Can you please post what versions are you using?

I'm sorry, I'm using those versions and all I get is a WSOD.

Should we post any issues with any admin themes at all? Just asking so as not to pollute the thread

I removed all references to Rubik and Tao.

Yes. It needs to look good in Stark first. In theory, if the base CSS looks good in stark, then anything else is going to be adjusting for quirks in the CSS and we can let admin themes handle that.

Now, major problems with major themes we can deal with, *if* it's sensible to do so.

Can anyone please review #10 with Stark, Bartik and Seven and report issues..

Just a quick note for those folks who happen to wonder in here with issues with Rubik. I slapped together a temp CSS file that should solve most of the issues with the latest Views 3 Dev version and Rubik. Not a permanent fix but it should hold them over for the time being until things get cleaned up.

I hope that is ok to post this, my apologies if it is not. I figure it could save everyone some headaches:

http://drupal.org/node/1101086

@riyasmtpm
Don't abduct issues. Nobody will help you here. You need to open a new issue with your question, and wait there.

Removing irrelevant tag as an excuse to sub :)

@kannary what's the difference between the patches in this issue and the one in http://drupal.org/node/1101086

@lelizondo:

It is not a patch. It is simply a temporary CSS for people using Rubik that do not want / cannot switch to Seven for whatever reason. (my case)

Patches here are for Seven and Stark.

If you have any questions post them in the issue at that link, not here.

Subscribe.

On Garland, the main problems are:

- buttons are far too big
- dividing lines are faint to the point of being invisible

Will test the patch when I have time :)

@lelizondo I'm verifying #10

@lelizondo I'm having trouble applying your patches. I need to go through them and remove the a/ and b/ characters in the paths e.g.

diff --git a/css/views-admin.css b/css/views-admin.css

Are you creating the patches from the root of your views module?

To apply, I cd to the root of my views module, then run

patch -p0 < path-to-patch/file.patch

@jesse
When the patch has a/ and b/ (which is the new default patch format), you apply the patch with "patch -p1 < file.patch" (from the root directory)

@jessebeach there are multiple files affected in the patch, that's way you should apply the patch from the views root directory

@bojanz and @lelizondo, got it, thanks for clarifying. @lelizondo, sorry to imply you were doing something incorrectly. I should have added the caveat that it was most likely something I was doing, which ended up being the case.

no problem @jessebeach

please report back with issues you find with the patch.

Patch fixes the button size for me, but it doesn't change the faintness of the lines.

Also, display name hover is funny on Garland.

This patch incorporates @lelizondo's changes and extends them. I moved as much presentation code from views-admin.theme.css to views-admin.seven.css as I felt I could without completely gutting .theme.css. Views should have a basic look and feel. For example, the rounded corners on buttons and font colors were moved to .seven.css, but the colors for borders were not, since these are sufficiently agnostic to a particular admin theme. The borders also chunk the ui up visually and make it easier to use.

changing the title of the issue to reflect that these changes affect Stark only.

List page

• The reset button is poorly positioned.
• The dropdown buttons are still oddly large.

Edit page

• Bucket headers are all-capsed, which seems out of place. That's a seveny thing.
• The UI is oddly wide; I have nothing apparently pushing it open, and this same view isn't > 1000px in Seven.
• All of the text in the modal seems really big.
• Like on the edit page, dropdown buttons oddly large.

All in all that's not many complaints.

Hmm. Scratch that.

I applied then unapplied the patch and things changed.

Despite that I cleared caches and shift reloaded multiple times., (*&)(*&)(*ing Chrome.

Ok, the buttons are normal.

Modal text still oddly large, UI still oddly wide, bucket titles still all-capsed.

The UI seems to be getting pushed wide by the query in pre.

Crosspost killed title.

@merlinofchaos, I think that when you say the Ui is oddly wide, you mean that the content (tables, right?) are busting out of the viewport width, not that that the page fills the viewport 100%.

This patch incorporates changes for these issues:

• The reset button is poorly positioned.
• Bucket headers are all-capsed, which seems out of place. That's a seveny thing.
• The UI is oddly wide; I have nothing apparently pushing it open, and this same view isn't > 1000px in Seven.
  • The UI seems to be getting pushed wide by the query in pre.
• All of the text in the modal seems really big.

Seriously rockin' work on this! The UI is usable on Stark. And yes, it was busting out of the viewport because of the long query. A little wrapping helps, though I think there's still a bigger problem that I want to see if we can deal with.

@merlinofchaos, I added white-space:pre-wrap to the <pre> elements. They shouldn't be busting the page wide any more. A wide table though, would still bust the page width.

Yeah. I would like to separate the preview and the main UI so that can't happen. I'm going to create a separate issue for that.

That's here: http://drupal.org/node/1104204