Closed (fixed)
Project:
Markdown with SmartyPants
Component:
Documentation
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
21 Sep 2004 at 20:31 UTC
Updated:
6 Oct 2004 at 23:20 UTC
The html documentation in marksmarty contains hyperlinks to markdown/#overview etc. This only works for sites that have clear URLs enabled. Sites that don't have clear URLs need links like ?q=markdown/#overview. The latter also works for sites with clear URLs. I suggest changing all links to the non-clear-URL, since that works for everybody. The alternative would be to let PHP change the ULS dynamically according the system's settings, but that seems like overkill (on the other hand; it would look better).
I include a patch for the first option (against cvs revision 1.6).
| Comment | File | Size | Author |
|---|---|---|---|
| marksmarty.module.diff | 2.87 KB | Philippe |
Comments
Comment #1
Philippe commented(I need to set the status to "Patch" if I include a patch ;-)
Comment #2
teradome commentedI needed to update the syntax documentation anyway to reflect the inclusion of PHP-Markdown v1.0. Saw those links and knew they were not kosher. I'm going to try addressing this as pure namerefs, a la href="#overview" since most user-agents will change page locations on the local copy without making a new request--which is preferable. Let's hope Drupal is cool with that.
Comment #3
teradome commentedDrupal was not cool with it (forgot about the BASE tag the theme system throws in) so the "?q=markdown/#anchor" format was applied to CVS. Will be applied to 4.4 later tonight. I will close this issue after I get some confirmation feedback on the change.
Comment #4
(not verified) commented