I've read that the author of Thickbox is moving over to Colorbox because "the Thickbox script is getting a bit old and is cumbersome to maintain well for all new browsers (- frjo)."
I've installed the Colorbox module because I wondered if this could be applied on Disclaimer. Unfortunately it's not possible to enable it as modal jQuery plugin.
Will this be possible in the future for D6 and D7?
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | colorbox-disclaimer2.gif | 179.67 KB | knalstaaf |
| #6 | colorbox-disclaimer.gif | 129.23 KB | knalstaaf |
| #6 | colorbox-disclaimer2.gif | 179.67 KB | knalstaaf |
| Afbeelding 1.png | 48.13 KB | knalstaaf |
Comments
Comment #1
knalstaaf commentedCool! The Disclaimer module is an absolute bless, so I think it would be much appreciated - Thank you :)
Comment #2
mogtofu33 commentedColorbox support added in 6.x-2.x.
No more jqModal and nyroModal support.
Please test and give feedback.
Regards.
Mog.
Comment #3
mogtofu33 commentedComment #4
knalstaaf commentedNeedless to say, I'm looking forward to test this new feature! I already have been looking around for this. Enabled the Colorbox-module, which didn't seem to work, then downloaded the colorbox files from its development website and put them in a "colorbox"-folder right in the "Disclaimer"-folder, with no result. In both cases no modal script was found.
First thing that pops to my mind is that I haven't done this the way it's supposed to be. Can you give some installation guidance please?
Comment #5
mogtofu33 commentedHi,
There is no need to put any colorbox script to disclaimer folder, colorbox need only to be working normally.
There was a script error on ie6 ie7, corrected on next dev release, if you can't wait next dev generation, here is the modified script to replace : http://drupalcode.org/project/disclaimer.git/blob_plain/refs/heads/6.x-2.x:/disclaimer.js
Please test with default disclaimer settings and don't forget to emty your browser cache.
If not working can you tell me if you see script on my test domain : http://test-disclaimer.arthurp.fr
Regards.
Mog.
Comment #6
knalstaaf commentedIt's working on the provided page indeed, but not in my installation. It still says "Can't find any modal script. Please see INSTALL.txt.". I'm testing it on a clean Drupal 6.20 installation (with only those modules installed and enabled: Colorbox, Disclaimer and Jquery-update).
I've attached screens of my settings, just in case you'd find a misconfiguration there (I don't seem to see it).
Comment #7
knalstaaf commentedColorbox is not being displayed in "Display Fields" when configuring the content type. So I think it must be a Colorbox misconfiguration, eventhough I reckon that all the files are at their proper place (jquery update 2, libraries/colorbox/(entire content zip file), admin page of colorbox working fine, no errors in status report, ... can't think where it goes wrong).
Comment #8
knalstaaf commentedGot the Colorbox module working finally, but no progress on the Disclaimer front so far. Still the "Can't find any modal script. Please see INSTALL.txt." notice. (Cleared the cache)
Comment #9
knalstaaf commentedRight, this is embarassing: I was still testing with 6.x-1.9. My apologies, Mog. I deserve a swift kick in the bollocks.
Now the Colorbox opens, but the white box just goes over het whole screen, and all it says is "Request unsuccessful: Not Found".
Comment #10
ñull commentedThis seems to work with Colorbox 6.x-1.x-dev (2011-Apr-16) and jQuery Update 6.x-2.0-alpha1, but I don't know if the functionality is according to specification.
Should the disclaimer appear only once after accepting (and correct age limit) or should it appear every time you visit the selected page(s)? I see the Disclaimer appear every time and I find it hard to believe that this was the intention of the designer. What is the function of the cookie then if the previous acceptance apparently is not saved?
Comment #11
ñull commentedI installed jQuery Update 6.x-2.0-dev . It works on most browsers now but not on IE (version 8); apparently the cookie that remembers the choice (age) is not written.
Comment #12
ñull commentedThe IE8 cookie was written when I manually put the cookie domain. My domain is a sub-domain like shop.domain.com so may be that has to do with it?
Comment #13
RAFA3L commentedI'm testing all versions of Disclaimer, Colorbox and JQuery Update and the big white window with "Request unsuccessful: Not Found" still there
Comment #14
RAFA3L commentedAfter change a few lines now it work fine with Colorbox 6.x-1.x-dev, JQuery Update 6.x-2.0-alpha1 and Disclaimer 6.x-2.x-dev
Add before // colorbox in disclaimer.module, or inside settings array
'content' => _disclaimer_get_content(),
And change in disclaimer.js
href:"/disclaimer",
To
html:Drupal.settings.disclaimer.content,
Comment #15
mogtofu33 commentedI fixed a base_path error on next dev release and add RAFA3L code (december 14, 2011).
Cookie domain with ie 8/9 is fixed.
But there is a problem with default colorbox theme, content is under the popup, there is a problem with #cboxMiddleLeft width in colorbox.css... i will try fixed this issue to get an official 6.x-2 release.
Regards.
Mog.
Comment #16
mogtofu33 commentedTo fix bug with colorbox default style css, we need to add this css:
body #cboxMiddleLeft,
body #cboxMiddleRight,
body #cboxTopLeft,
body #cboxTopCenter,
body #cboxTopRight {
display:none;
}
#cboxLoadedContent {
margin: 10px;
}
I'll add this css on disclaimer-6.x-2 official release.
Comment #17
avpadernoI am closing this issue, as it has been created for a release that is now not supported.