by day recurrance rules cause infinite loop if PHP4 compat code is *not* loaded [#1105858]

On PHP 5.2 or 5.3, without the PHP4 date module loaded, date_modify doesn't work with stanzas like "+1 Sunday".

That means that the following piece of code:

if (date_format($current_day, 'l') != $day) {
date_modify($current_day, '+1 '. $day);
$moved = TRUE;
}

in date_repeat_calc.inc causes infinite loops when trying to compute by day rules.

It appears that just commenting out those 4 lines makes things work again, though as I don't know other ramifications of this, I'm not including the patch.

Comment	File	Size	Author
#10	0001-Issue-1105858-by-sdague-check-to-make-sure-we-actual.patch	1.41 KB	sdague
#1	0001-Issue-1105858-by-sdague-check-to-make-sure-we-actual.patch	1.35 KB	sdague

Comments

Comment #1

sdague commented 26 March 2011 at 13:05

Status:

Active

» Needs review

Status	File	Size
new	0001-Issue-1105858-by-sdague-check-to-make-sure-we-actual.patch	1.35 KB

The following patch seems to be a safe fix for this. It basically just checks to see if the date actually changed at all before it sets $moved so that we don't loop forever without moving forward. After doing this imports of all manner of odd recurrance events work, and don't put us into an infinite loop. This works with either the Date PHP4 module loaded, or with it not loaded on PHP5.2 or 5.3.

Comment #2

sdague commented 5 August 2011 at 22:30

Bump. It would be nice if someone looked at this.

Comment #3

karens commented 7 August 2011 at 23:17

The project page says PHP 4 issues are receiving little or no support. We are now supporting PHP 5.2 and PHP 5.3 across two versions of Drupal, which is already more than I can reasonably accomplish. PHP 4 is ridiculously old at this point and there are tons of other problems with it when it comes to using dates.

Comment #4

sdague commented 21 August 2011 at 19:51

Title:

by day recurrance rules cause infinite loop if PHP4 compat code is not loaded

» by day recurrance rules cause infinite loop if PHP4 compat code is *not* loaded

The issue *isn't* using PHP4.

The issue is that when you disable the Date PHP4 compat library on a PHP 5.2 / 5.3 installation things go wrong. The Date PHP4 compat library has more features than the actual date implementation in PHP 5.2 / 5.3. The Date library depends on these features when parsing recurring dates, and thus *breaks* on PHP 5.2 / 5.3.

I'm all for dumping PHP4 support, but this is an issue where things break unless you load PHP4 compatibility code on new PHP, which seems pretty broken.

Comment #5

tomdisher commented 18 September 2011 at 23:52

This patch seems to be working for me - brilliant. Thank you!

Comment #6

jspayne commented 21 September 2011 at 14:50

Subscribing - this patch needs to be integrated. Solved my problem as well.

Comment #7

karens commented 27 April 2012 at 09:35

Status:

Needs review

» Postponed (maintainer needs more info)

The '+1 Sunday' code works fine in D7 where we don't even have a PHP4 module. I can't see any reason why this wouldn't work fine as-is. The code in date_repeat_calc.inc is the same in D6 and D7 and I've received no reports of problems in D7.

I need steps to reproduce a problem in D6.

Comment #8

sdague commented 19 May 2012 at 01:58

Status:

Postponed (maintainer needs more info)

» Needs review

The situation that creates this issue:

Using feeds + ical_parser to load ical feeds and create nodes out of them. ical_parser calls down into date_repeat_calc.inc to do it's ical manipulation. If it runs into an event with an RRULE (especially those with EXCEPT or ADD in the mix), without this patch it goes into an infinite loop, eventually crashing with a PHP timeout.

All this patch makes sure is that the date_modify actually moved forward before setting $moved. It's a safety check.