UC Authorizenet Multi

You should mention this is an Ubercart add-on, otherwise it doesn't show up when people search for Ubercart contributions.

Tagging for easier finding.

Hi,

First, let me apologize in the name of the Drupal community for the review process to take so long. We are trying to make it better here.

How is this module any different from this one or this other one ?

If your module's just adding a feature, have you tried contacting these modules' maintainers to co-maintain or propose a patch?

In addition to the two modules Ralt pointed to, this might also be considered as an addition to the uc_authorizenet module that is part of the main Ubercart project.

Sounds like there's a reasonable case for keeping it separate. Switching status back to "needs review."

subscribing.. I have a client who is interested in this as well, a hair salon with multiple locations

I've got a client; it's a non-profit that has a separate center running inside the bigger non profit. Just one web site, currently using authorize.net to collect donations with Ubercart. The center has grown to the point where they are raising their own funds. Ultimately they may have their own web site, but right now they'd like to use the whole Ubercart set-up of the parent institution, but simply designate certain product pages for payment to a new Authorize.net account that they will set up.

In short: this module is exactly what I need and no other module provides this.

I'd like to see this approved as soon as possible.

Shai Gluskin

Shai, you can help get it approved faster by doing a review according to the documented process.

Suggestions

Please take a moment to make your project page follow tips for a great project page.

readme.txt should be README.txt

507 db_query("REPLACE INTO {uc_authorizenet_multi} (nid, profile_id) VALUES ('%d', '%d')", $node->nid, $profile_id);

This is a mysql-ism and should either be documented that the module is mysql only OR changed to use an update query, db_affected_rows, and then an insert query (core uses that pattern quite often).

The spacing on uc_authorizenet_multi.pages.inc seems to be a bit off - maybe you are using tabs instead of spaces?

Required changes

The comment says this is just for testing - how do you take the module out of testing mode?
<?
40 function uc_authorizenet_multi_profile_edit_access() {
41 return TRUE;
42 }
?>

If the module requires curl you should check for its existence in a hook_requirements. This will avoid fatal errors on sites without curl.

495 $result = db_query("SELECT nid,profile_id FROM {uc_authorizenet_multi} WHERE nid='%d'", $node->nid);

The %d placeholder is for integers which should not be enclosed in '', please remove the ' around the %d.

Multi authorize. net module currently support Ubercart and Drupal 6 and allows site administrators to configure multiple authorize. net accounts to their online store and then associate any product to that particular authorize. net account. When user buy this product the payment will go to that specific account. Very easy to configure, administrate and use on Ubercart installations.

How To Configure Multi Authorize. net Module

• Navigate to admin/store/settings/payment/edit/gateways and open the Authorize.net Multi settings fieldset.
• Enter the number of profiles (ie. Authorize.net accounts) you would like to use and click Save configuration
• Click the unnamed profile; configure API Login ID, Transaction Key, Transaction Mode, and other settings. Click Submit.
• Do this for all added profiles
• Create a product node. Under Product information, there is a Payment Gateway Profile dropdown; select the appropriate gateway

more information available here http://www.crossmediaglobal.com/html/drupal-ubercart-multiauthorizenet-m...

How can they sell it? What extra added value are they adding that doesn't break GPL? If the module is posted on Drupal.org it's GPL and the module itself can't be sold.

I don't believe this does actually break the spirit or the law of the GPL, but IANAL (I am not a lawyer). If you think it does you can hire a lawyer to help you prosecute it.

It does break my personal sense of what's "right".

This is all pretty tangential to this issue. The best way, IMO, to block them is to get this one finished off and approved for drupal.org where people will find it very quickly (d.o project pages have great SEO).

@rj - I think there's just a few things for you to work on to finish this off. I'll gladly review it again once those are done.

Looking forward to help test as well

Hi,

1- I would like to notify that i am charging for support, customization, configuration and installation of this module and for your kind information this is not violation of any copyrights law.

2- I have the better one codded myself, if someone is interested please let me know i will send you the complete code and you may compare it with the one already exists.

3- Charging to your clients for any open source development, customization, integration, installation and configuration is not a violation of any copyright/GPL.

4- If this is the case then all open source including drupal, joomla, wordpress they should ban any customization and chages in their code.

Please let me know if i am wrong anywhere and still if its not acceptable for World Wide Web Community i will remove every thing.

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
Review of the master branch:

• Drupal Code Sniffer has found some code style issues (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.

manual review:

• _uc_authorizenet_multi_requirements_runtime(): this function definition appears two times, your code will throw fatal errors.

I know, getting feedback on your application took long, you can speed up the process with #1410826: [META] Review bonus.

Closing due to lack of activity. Feel free to reopen if you are still working on this application.