Posted by boombatower on March 29, 2011 at 4:39am
10 followers
| Project: | Drupal core |
| Version: | 8.x-dev |
| Component: | node system |
| Category: | task |
| Priority: | normal |
| Assigned: | boombatower |
| Status: | needs review |
Issue Summary
Just as node/%node is a parent item for view, edit, delete so should node/%node/revisions/% be the parent for view, revert, delete.
Comments
#1
#2
Not sure if delete should be included since it isn't for node/%node/delete.
#3
Re-rolled against current head. I left delete included, although I agree that it's removal should be considered for consistency.
#4
re-rolled with bugfix.
#5
Here's another option for consideration - rather than making the revisions actions local tasks, I put them as local actions.
#6
The last submitted patch, 1108888-node-revisions-rev4.patch, failed testing.
#7
#4: 1108888-node-revisions-rev3.patch queued for re-testing.
#8
#5: 1108888-node-revisions-rev4.patch queued for re-testing.
#9
The last submitted patch, 1108888-node-revisions-rev4.patch, failed testing.
#10
#4: 1108888-node-revisions-rev3.patch queued for re-testing.
#11
#5: 1108888-node-revisions-rev4.patch queued for re-testing.
#12
#5: 1108888-node-revisions-rev4.patch queued for re-testing.
#13
Patch applies correctly.
#14
#5: 1108888-node-revisions-rev4.patch queued for re-testing.
#15
Hm, can someone take a screenshot of what this does? I can't quite parse it from the description, nor from reading the code.
#16
Changed two cases of MENU_LOCAL_ACTION in patch to MENU_LOCAL_TASK
Shorter tab labels would be good with hover over for extra description.
#17
The last submitted patch, node_revisions-1108888-16.patch, failed testing.
#18
Here are before and after shots:
Before:
After the patch in #4:
After the patch in #5:
After the patch in #16:
After seeing these images, a quick comparison of the patches in #4 & #16 indicates that #16 is a re-roll of #4.