On line 36 of views-view-table.tpl.php there is a missing double-quote after 'class=' which can cause severe headaches when trying to style table delimiters (or children of) with CSS. I'm not sure the proper procedure for submitting this so here it is. If someone wants to tell me the proper procedure I'll be happy to follow it next time.

Incorrect:

print $fields[$field]; ">

Correct:

print $fields[$field]; ">

Other than that I'm loving the theme! Just switched from Genesis, which is another great one.

Comments

nickbn’s picture

Oops... forgot code brackets

Incorrect:

          <td class=<?php print $fields[$field]; ?>">

Correct:

          <td class="<?php print $fields[$field]; ?>">
blackey5000’s picture

Status: Active » Needs review

Bumping this issue thread and changing it's status to "needs review". OP gave the solution, so I just wanted to make sure it was going to get committed to the next release.
Thanks

Jeff Burnz’s picture

I'll check if this is in 6.x-3.x, I think it is, but its been a while since I worked on the 6x versions.

oriol_e9g’s picture

Component: Code » CSS/HTML

I can confirm that this error is present in 6.x-2.2 and 6.x-2.x-dev but it's not present in 6.x-3.0-rc2 because the views template overrides has been removed in 6.x-3.0-rc1.

Jeff Burnz’s picture

What I will do is backport the fixes (remove the views template override or fix the actual issue) to 6.x-2.x, I am going to kill off the 6.x-3.x branch and make one more maintenance release for Drupal 6.

Jeff Burnz’s picture

Scrub that, I am actively improving the 3x for a new release, so this still needs to be fixed in 2.x.

Jeff Burnz’s picture

oriol_e9g - you reported this was still in dev, well, I just pulled dev from GIT and its been fixed, ages ago in DEV, I can see from the commits.

Not sure what you were looking at. Getting ready for a new release of 6.x-2.x.

Jeff Burnz’s picture

Status: Needs review » Closed (fixed)
Jeff Burnz’s picture

This is strait out of GIT for 2.x dev:

<table class="<?php print $class; ?>">
  <?php if (!empty($title)) : ?>
    <caption><?php print $title; ?></caption>
  <?php endif; ?>
  <thead>
    <tr>
      <?php foreach ($header as $field => $label): ?>
        <th class="views-field <?php print $fields[$field]; ?>">
          <?php print $label; ?>
        </th>
      <?php endforeach; ?>
    </tr>
  </thead>
  <tbody>
    <?php foreach ($rows as $count => $row): ?>
      <tr class="<?php print implode(' ', $row_classes[$count]); ?>">
        <?php foreach ($row as $field => $content): ?>
          <td class="views-field <?php print $fields[$field]; ?>">
            <?php print $content; ?>
          </td>
        <?php endforeach; ?>
      </tr>
    <?php endforeach; ?>
  </tbody>
</table> <!--/views-view-table.tpl.php -->