Why does this module require the Fields UI module? I like to disable that when its not in use to reduce the amount of PHP needed to compile each page (think "disable developer modules"). Can you remove that dependency?

CommentFileSizeAuthor
#4 remove-field-ui-dependency-1114134-4.patch1.63 KBjoelstein
#1 remove-field_ui-dependency-1114134-1.patch361 bytesgeerlingguy

Comments

geerlingguy’s picture

geerlingguy commented
Status: Active » Needs review
StatusFileSize
new remove-field_ui-dependency-1114134-1.patch361 bytes

Subscribe, and seconded. While this module is dependent on fields_ui to configure the fields (at least, normally), its main functionality (that is, providing access control for fields) has no dependency on the fileds_ui module to continue working.

joelstein’s picture

joelstein commented

And, since Admin Menu added Fields UI to its list of developer modules, this seems like an ideal time to remove this dependency.

fietserwin’s picture

fietserwin
Location Le Mont-Dore
commented
Status: Needs review » Needs work

- I think that the readme should be updated to reflect this change as well.
- Aren't there any dependencies in the part of the code that also gets executed in non developer mode?

joelstein’s picture

joelstein commented
Status: Needs work » Needs review
StatusFileSize
new remove-field-ui-dependency-1114134-4.patch1.63 KB

Here's an updated patch with revised instructions in README.txt. And no, there is no part of this module which executes code in Field UI except for that which is needed for configuration. I've been using patch (in #1 above) for many months now with great success.

fietserwin’s picture

fietserwin
Location Le Mont-Dore
commented
Status: Needs review » Reviewed & tested by the community

Patch is OK and my concern has been taken away by the previous comment...

geerlingguy’s picture

geerlingguy commented

Looks good to me too!

joelstein’s picture

joelstein commented

Great, can we get this committed?

robloach’s picture

robloach
he/him
commented
Status: Reviewed & tested by the community » Fixed

Thanks a lot, guys! http://drupalcode.org/project/field_permissions.git/commit/62a8b98

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

arpas’s picture

arpas commented
Version: 7.x-1.x-dev » 7.x-1.0-beta2
Category: feature » bug
Status: Closed (fixed) » Needs review

But one problem rest. If I go to the page admin/reports/fields/permissions I get an error 'Fatal error: Call to undefined function _field_ui_bundle_admin_path()'. I suggest to change this error to "Enable/install Field UI module" but I don't know how.

Status: Needs review » Needs work

The last submitted patch, remove-field-ui-dependency-1114134-4.patch, failed testing.

  • RobLoach committed 62a8b98 on 8.x-1.x 
    Issue #1114134 by geerlingguy, joelstein: Added Remove dependency on...
mariacha1’s picture

mariacha1 commented
Issue summary: View changes
Status: Needs work » Closed (duplicate)

Remaining issue is covered in https://www.drupal.org/node/2364587 and doesn't seem to be a problem in D8. (I think)