Issue Macros and Templates

[Edit]
Please watch my http://drupal.org/sandbox/clemenstolboom/1125712

[Edit]
The attached patch makes a ajax request to http://drupal.org/node/467548 childpages of http://drupal.org/node/1120672 to get to our definition list.

It is not ready yet but it works a little ;)

Things to solve:

- caching of the dd items into local storage
- make it a tree of items so a duplicate has more reasons
- better ui ? The list appears now above the 'Create triage message'

See also #651834: Git applications queue support for more ideas.

This is how it works right now.

This patch now uses http://drupal.org/node/1118110 as it's source document.

It is now possible to have several reasons for each issue Status.

When there is no DD in the source document for a particular DT the link is not active.

See the attached screenshot of this particular issue ;)

Added a banner to get this up to speed.

Powered by dreditor (triage patch) and Triage transitions

Changed the title to make it more attractive for irc

@sun remarks:

1. Caching and source control
Caching See #2 (how store settings)
Source control? What do you mean by that?

2. It's possible to have multiple sources but I need UI feedback to make this nicer.
The new patch has now two sources for triage. So it's possible to have more.

But for that I need to know how to store settings ... it's in dreditor somewhere?

3. How is this current working in dreditor?
My ideas are related to this current state ... dim items not related to current state, assign to, etc.
Where is this in dreditor code?

4. Is this mere UI or context based?
I want to add config settings to filter out / dim categories based on 'whatever'

5. macros
Sounds ok to me ... a macro is at least not a .tpl.php

Anyway ... I want this patch useable asap for the project application issues.

Known issues are:
- toggle is not working properly ... needs get fixed asap
- caching is not done
- no config

I would like to have a workable first then do 'config' and 'caching' in different tickets although it doesn't sound to complicated.

What do you think how to implement this feature quickest?

Added definition list DL bug #1120618: CSS misses layout of nested definition lists to help displaying http://drupal.org/node/1119350 correctly.

Current version:
- moved triage items into separate div
- using storage but having issues with global storage (is this due to greasemonkey?) ... using local storage

Known issues:
- toggle is not working yet
- the code is placed somewhat in the wrong place (Drupal.behaviors.dreditorCommitMessage)
- there is no user customization. My guess is global storage is prohibited by greasemonkey which means we need a real firefox plugin. What do you think?

the attached patch needs review

Powered by dreditor (triage patch) and Triage transitions

Blast and testing ...

+++ b/dreditor.user.js
@@ -1389,6 +1389,149 @@ Drupal.behaviors.dreditorCommitMessage = function (context) {
+        local_1119350 : {
+	      url : './local-nodes/1119350.html',
+          description : 'Local Project Application'

Whitespace

Powered by Dreditor.

The code contains whitespace problems. The code contains whitespace problems. Please use http://drupal.org/project/coder to check your code.

Powered by dreditor (triage patch) and Triage transitions

The attached patch:

- cache implemented: local cache is working fine ... 'local' means site bound
- banner replaced with a source link

Known issues:

- toggle is not working yet
- the code is placed somewhat in the wrong place (Drupal.behaviors.dreditorCommitMessage)

Features still needed:

- auto discovery through http://drupal.org/node/1120672 by grabbing it's child pages

- setting status (and other issue values)
-- develop a macro language suitable for d.o page structures
--- is a @fieldname(new-value) and @old-fieldname a good start?

I moved this over to http://drupal.org/sandbox/clemenstolboom/1125712 which makes it way easier to follow all features in a working state.

Please take over the good parts asap ;)

As I have now a sandbox we can best test over there first and then mergeback into dreditor.git

This issue is waiting for #1136342: It's impossible to run unit tests due to return statement to get completed

Powered by Dreditor (triage sandbox) and Triage transitions

Should I add a patch here (It's functional without #1136342: It's impossible to run unit tests due to return statement)
or
expect people to use my sandbox version http://drupal.org/sandbox/clemenstolboom/1125712 which is runable?

Attached the latest version. Features are:
- Settings issue fields like status, tags, comment
- Getting issue fields
- Getting prompts for duplicate_issue, duplicate_project, depends_on_issue, blocks_issue

the attached patch needs review

Powered by Dreditor (triage sandbox) and Triage transitions

+++ b/dreditor.user.jsundefined
@@ -565,6 +565,35 @@ Drupal.storage.unserialize = function (val) {
+Drupal.storage.cache = {
+  set : function(id, cacheTable) {

Added cache support

+++ b/dreditor.user.jsundefined
@@ -614,6 +643,256 @@ Drupal.dreditor.form.form.prototype = {
+Drupal.dreditor.macro = {

Added macro

+++ b/dreditor.user.jsundefined
@@ -1455,9 +1734,244 @@ Drupal.behaviors.dreditorCommitMessage = function (context) {
 
+Drupal.dreditor.triage = {

Added triage UI

Powered by Dreditor.

Watch the video on http://www.youtube.com/watch?v=vpyZu9467yc

For the macro's we need get/set/old/query constructs. I skipped that at first and did my own construct as I was afraid of token clashes. But on second thought ...

Tokens are (D7) just [$type:$name] for get/old constructs and [$type:$name _VALUE_] for set and [$type:$name ?] for query.

Get/oldGet [issue:tags] [issue:comment] [issue:oldTags]
Set [issue:status 3] [issue:tags -D8CI]
Query [issue:reference] [project:reference]

Regarding the UI/UX

I hate mouse move so for me the current UI is fine (one big blob) but we can do both I guess. I'll try to consult bohjan.

The puzzle I solved with the @oldX() construct like (taken from http://drupal.org/node/1118110)

Fixed @status(2) @oldStatus(active) @oldStatus(needs review)

is to indicate Fixed is only relevant for 'Active' or 'needs review' issues (a state transition). It is easy to parse by using 'old' for current state. My guess is the setters are easier to read compared to json as they are separated as strings.

A query like (taken from Stock response on http://drupal.org/node/1118110)
Depends on @depends_on_issue(?) would be better readable with a token construct like

This issue is blocked by [issue:reference Please give the depends on issue #]

I just tried to start fixing my sandbox #1280412: Tags are inserted multiple times and first added a test for that.

@sun: Please have a look at my test for macro's in action at http://drupalcode.org/sandbox/clemenstolboom/1125712.git/blob_plain/refs... or visit http://drupalcode.org/sandbox/clemenstolboom/1125712.git/blob_plain/refs...

There is a lot of effort done in the tests. I'd opt for leaving macros as is and focus on template for token.

About macro versus template
- templates are what is inserted into the issue comment
- macros are manipulating the issue state. (I know comment is part of the state)
What do you think?

Apart from the macro construct I think this is now ready for review :-)

See #1141242: The query macro @field(?) seems a little duplicate

[edit]The image below is the current state.

[edit] end of image

The attached patch has 3 chunks

#1 is for my unit tests ... see #1136342: It's impossible to run unit tests due to return statement
#2 is the triage patch
#3 is for my unit tests to have the buttons visible

See http://drupal.org/project/1125712/git-instructions or run the unit tests straight from http://drupalcode.org/sandbox/clemenstolboom/1125712.git/tree/refs/heads...

For open issues see http://drupal.org/project/issues/1125712

Changed the whole text and added the demo video.

Implemented the Issue Template

Added link to D8CI-DOCS gates as an useful example

Fixed close tag on link

Updated issue summary.

Added image

Update image

The sandbox is active. It contains #1345614: Merging toggle buttons to a more consistent UX which is bad. Anyway it looks like this
==== image begin

==== image end