Posted by drastik on April 6, 2011 at 12:10am
4 followers
Jump to:
| Project: | Drupal.org Project applications |
| Component: | module |
| Category: | task |
| Priority: | critical |
| Assigned: | Unassigned |
| Status: | closed (won't fix) |
| Issue tags: | PAReview: CiviCRM |
Issue Summary
CiviCRM allows you to include custom fields (Profiles) on a contribution form, but only at the TOP or BOTTOM of the form. This module allows you to include custom data fields INSIDE the Honor / Memorial section.
This module is being submitted as requested by dlobo (Donald Lobo) of the CiviCRM project. He also stated that it is ok to include the custom CiviCRM template files.
Project page:
http://drupal.org/sandbox/drastik/1117498
Comments
#1
Coder does not like CiviCRM's "camelCase" hooks :)
#2
#3
Tagging this to make it a little easier for someone who knows CiviCRM to find it.
#4
Changing priority according to the new priority guidelines.
#5
Hi drastik,
I feel ridiculous bringing up anything after you've waited five months for review, but could you add PHPdoc style code comments to the functions? Check spacing and such.
And as my personal main criteria for why someone should be able to promote projects to full status is that they will continue to maintain them, if there have been any bugs reported or fixes made in these past months, it would be great to see those rolled in.
Lobo is certainly best qualified to assess CiviCRM integration code. Pretty much, show you haven't forgotten how to use Git to maintain a module and we'll grant you promoting-to-full-project capability.
Thanks for your patience.
#6
The applicant has been contacted to ask if the application is abandoned.
#7
The applicant answered that the application is not abandoned.
#8
I'm going to try and make these changes and re-upload this weekend.
#9
Just a friendly reminder to update your git repo.
#10
Sorry, I'm just going to scrap this. I haven't worked for the company doing CiviCRM sites in over a year and I just don't have the time. There have been several new versions of Civi since, including a major release version upgrade so it may not even be compatible.
Should I delete this the project or?
#11
No harm in leaving the sandbox project up, in case someone wants to use the code for something. I'm closing this issue. You can open a new issue when you have a new project.