Closed (duplicate)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
6 Apr 2011 at 00:10 UTC
Updated:
10 Sep 2018 at 10:09 UTC
Jump to comment: Most recent
Comments
Comment #1
jwjoshuawalker commentedCoder does not like CiviCRM's "camelCase" hooks :)
Comment #2
jwjoshuawalker commentedComment #3
sreynen commentedTagging this to make it a little easier for someone who knows CiviCRM to find it.
Comment #4
ralt commentedChanging priority according to the new priority guidelines.
Comment #5
mlncn commentedHi drastik,
I feel ridiculous bringing up anything after you've waited five months for review, but could you add PHPdoc style code comments to the functions? Check spacing and such.
And as my personal main criteria for why someone should be able to promote projects to full status is that they will continue to maintain them, if there have been any bugs reported or fixes made in these past months, it would be great to see those rolled in.
Lobo is certainly best qualified to assess CiviCRM integration code. Pretty much, show you haven't forgotten how to use Git to maintain a module and we'll grant you promoting-to-full-project capability.
Thanks for your patience.
Comment #6
misc commentedThe applicant has been contacted to ask if the application is abandoned.
Comment #7
misc commentedThe applicant answered that the application is not abandoned.
Comment #8
jwjoshuawalker commentedI'm going to try and make these changes and re-upload this weekend.
Comment #9
misc commentedJust a friendly reminder to update your git repo.
Comment #10
jwjoshuawalker commentedSorry, I'm just going to scrap this. I haven't worked for the company doing CiviCRM sites in over a year and I just don't have the time. There have been several new versions of Civi since, including a major release version upgrade so it may not even be compatible.
Should I delete this the project or?
Comment #11
sreynen commentedNo harm in leaving the sandbox project up, in case someone wants to use the code for something. I'm closing this issue. You can open a new issue when you have a new project.
Comment #12
jwjoshuawalker commentedThis has been slowly eating at me for a while leaving this here. I realize how quickly it could have been cleaned up & approved.
Please review after last commit. Code is commented, cleaned up, and implemented other modern practices for PHP 5.3 compatibility.
As for the future, being back as freelance has given me much more time and desire to pursue my own projects & my community activity has increased 100 fold over the last 4 months. (I will be almost instantly able to tackle support/feature requests).
Comment #13
klausiComment #14
klausiPlease fix the automated review report first: http://ventral.org/pareview/httpgitdrupalorgsandboxdrastik1117498git
We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)
Comment #15
klausiComment #16
jwjoshuawalker commentedOh wow, old branch in there. Yeah look at the current branch now or master...
I deleted that old one.
Comment #17
jwjoshuawalker commentedGood lord this thing hates Zend Studio... even w/ appropriate code style settings plugged in.
Comment #18
carwin commentedClosing this so that http://drupal.org/node/1722212 can proceed.
Comment #19
jwjoshuawalker commentedOk, passes coder on everything except camelCase which is required for CiviCRM functions:
http://ventral.org/pareview/httpgitdrupalorgsandboxdrastik1117498git
BTW, is there a way to get the review logic that ventral.org is using? My version of coder only shows half of the things that ventral's does.
Comment #20
avpaderno