[D7] CiviCRM Stripe

Code too short

This project is too short to approve you as git vetted user. We are currently discussing how much code we need, but everything with less than 120 lines of code or less than 5 functions cannot be seriously reviewed. However, we can promote this single project manually to a full project.

Master Branch

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.

project page

Please take a moment to make your project page follow tips for a great project page.

Libraries API

You should consider using the libraries-module for the vendor js and php files needed by this module.

I'm changing the project-status to "needs work" because of the project-page, and the master-branch.

Your branches are named wrong: 7.x-1.0 -> 7.x-1.x
Also it's better if you don't create tags until you actually can create releases.

Set an appropriate branch other than master: http://drupal.org/node/1659588.

git checkout 7.x-1.x
git branch -D master
git push origin :master

Hi,

You should try to do something like that

  * @param string $formName
  *   The name of the form.
  * @param array $form
  *   Reference to the form object.

Where @param is following by the type of the param then the variable used.

Using http://groups.drupal.org/node/184389 and http://drupal.org/node/894256 as a template for this review.

README.txt

Check

project page

Check - As detailed as something like this could be.

Master Branch

Nope. Branches match naming conventions.

Major coding standards / best practice issues

An automated review of your project has found no issues with your code. The only conceivable issue is the camel case which can't be helped because that's how CiviCRM requires it to be.

License

No License file, check.

access administration vs. administer site configuration

Irrelevant for this since it's controlled by CiviCRM

files[] without classes or interfaces

None, check.

Licensing issues

No License file, check.

Multiple Applications

It appears that there have been multiple project applications opened under your username:
CiviCRM Honor Profile: http://drupal.org/node/1117556
* I talked with drastik on IRC and I closed Honor Profile so this is dealt with.

Already Approved

Wouldn't that be nice?

Idle Application

Nope, still active.

Code too short

There really isn't anything to be done about this for this particular module and I believe it should be granted an exception status. This module is simply a connector to CiviCRM's extension of the same name (and by the same author). Review his work on CiviCRM for more validation of his ability.

Duplicate module

No other module I've found adds Stripe as a payment processor for CiviCRM - this is such a specific module that there's not even another option.

Changing tag because I used the wrong one, changing status because I forgot to.

Sorry for the delay, but you have not listed any reviews of other project applications in your issue summary as strongly recommended in the application documentation.

Thanks for your contribution, drastik!

I promoted this project for you: http://drupal.org/project/civicrm_stripe

Now that this experimental project has been promoted, you'll need to update the URL of your remote repository or reclone it.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

Congratulations drastik!