This module gives a control in webform so that a user can create a number and float field for webform. This functionality is not existed so far for the webform and so many queries has been posted for this. This is my approach to solve the number and float field problem in the webform module.

I have uploaded it to my sandbox through GIT. please review the code.

Comments

clemens.tolboom’s picture

Each project application ticket needs a reference to the sandbox git file

Powered by dreditor (triage patch) and Triage transitions

abhishek.kumar’s picture

abhishek.kumar’s picture

Assigned: Unassigned » abhishek.kumar
Status: Active » Needs review
robloach’s picture

Might be better to get it into Webform core as quicksketch has shown interest: #260708: Number component (Numeric field)

sreynen’s picture

Assigned: abhishek.kumar » Unassigned
Category: feature » task
Status: Needs review » Needs work

By "needs work," I mean it needs a response to #4. If this can be added to an existing module, it should be closed.

abhishek.kumar’s picture

Component: new project application » module
Status: Needs work » Needs review
sreynen’s picture

Status: Needs review » Needs work

abhishek.kukku, please respond to what Rob Loach wrote in #4. Have you tried adding your code directly to the Webform module?

abhishek.kumar’s picture

Status: Needs work » Needs review

How can i add my code directly to webform module. quicksketch is responsible for these things because he is the author of webform module.

sreynen’s picture

Status: Needs review » Needs work

abhishek.kukku, you're right that quicksketch, as a maintainer of Webform, needs to accept your patch. I was going to explain to you how to submit code to the relevant issue, but it looks like you already did that. Sorry, I didn't see that before.

I also see now that quicksketch asked you to change your module into a patch and you responded:

I want it separate module so that no one can edit the code of webform and even the guy who don't know coding will use it like other module without going through the code.

I don't understand what you mean by that, but it doesn't sound like a good reason to have a separate module. "No one can edit the code" is very much not how we work on Drupal.org. We instead encourage everyone to get involved in improving code. Please let me know if I've misunderstood something. Right now, it looks like the next step is to reconsider quicksketch's request for a patch on Webform.

abhishek.kumar’s picture

Status: Needs work » Needs review

I have seen that number field issues with webform opened from 2008 and still its not added to webform. I am not getting why you guys want to put it as patch instead of separate module.

Can you tell me please how it would be better option to file as a patch of webform instead of separate module.

Some guys are asking me for d7 version of this also and i will port it soon for d7.

Thanks

sreynen’s picture

abhishek.kukku, you can find instructions for creating a patch here:

http://drupal.org/node/707484

Patches are how we contribute code to modules on Drupal.org. No one has posted a patch to that Webform number field issue yet, so there's nothing to add yet.

svendecabooter’s picture

Status: Needs review » Needs work

You should probably create a patch and try to get this into Webform module itself, before we consider creating a separate project out of this, as stated above.

abhishek.kumar’s picture

Assigned: Unassigned » abhishek.kumar
Status: Needs work » Needs review

Why you guys are trying to create this as patch. I show the discussion on this since 2008 and #quicksketch not provided this functionality in webform yet. So i think its better to create a separate project for it.

sreynen’s picture

abhishek.kukku, we're pushing patching the existing project over a new project because collaboration is one of the principles of Drupal. Projects are more successful when more people work on them together. Your statements about not wanting other people editing your code and expecting quicksketch to make all changes to Webform suggest you're approaching project maintenance on Drupal.org as a something individuals do by themselves, and that's just not how we handle projects here. Instead, we work together as a community. Does that make sense?

klausi’s picture

Status: Needs review » Closed (won't fix)

As others stated: please try to include your code as patches to webform first. Report back here if that showed to be not possible. Until then I mark this application as won't fix.

abhishek.kumar’s picture

Status: Closed (won't fix) » Needs review

@klausi: Can you tell me how i can file it as patch.

sreynen’s picture

Status: Needs review » Closed (won't fix)

Hi abhishek.kukku,

There are instructions here for creating a patch:

http://drupal.org/node/707484

If you have questions about that process, just let us know.