Port to 5.x

I follow up MFH's request.
I need this module in 5.0 version too.

I just want to second this. I know importing can be done manually - but node_import works so well and really should be available to encourage people move to 5.x. Does anyone have a sense of how hard / how long it will take to port?

I third this. node import was invaluable for me with 4.7.x. REALLY need this for 5

tracking the issue.

I might as well add my voice as it will be the deal-breaker for migrating to v5

I started with 5.0 about 2 months ago and just saw the node_import movie. This is definately something on my "must have" list. Where do I sign up? I want to add my name too. X

I'll start with the 5.x port next Monday. It should be usuable by the end of next week I think.

Yay.

subscribing

I can hardly wait. Good luck.

I am also waiting for 5.x version. Cheers.

Is there any news on this? I am not sure I am not the only one eagerly awaiting this. Are there any dev releases?

Ditto. Been waiting myself. Robrecht stated work was to start week or so ago. Any status?

Here's a comment Robrecht left on the 11th which suggests a tougher-than-expected task --
http://drupal.org/handbook/modules/node_import#comment-199212.

You have all our faith, Robrecht!

following progress.

I installed a fresh 4.7.6 installation and node_import and ran it. Maybe I don't know how to use it fully, but it seemed there was no place to put keywords or teasers from my old file.

Will it be possible to do this? If not, I might just have to organise a handcoded solution just to solve my own import problem. If I have to insert all keywords manually, and also manually change the categories for each node, maybe the import script won't save all that much time.

Any comments?

Yes it's tougher then expected. I'm about halfway there. I couldn't spend any time on it last week (very very busy), but I'll spend more time on it next week.

Sorry about the delay.

Hi Robrecht,

Very much appreciate the update. Very grateful you are able work on this. Your efforts are very much appreciated.

Please let us know if there is anything we can do to help (testing, etc).

Regards,

-pat

subscribing to issue.

Adding my hat to the ring.

Adding my name as well.

I used Node Import when prototyping a web site under 4.7 and although it couldn't do everything I needed, it got me close enough that some simple SQL was all that was required for final tweaking. It saved me many hours of additional work. Thank you Robrecht for your fine work.

I consider this module an absolute "must have" when moving large amounts of external data into Drupal.

To help things along the path toward a version for 5.0 I'd like to make a monetary donation specifically for the Node Import Module. Is there any way for me to do this?

In need of this feature as well...

subscribing

subscribing

Subscribing.

subscribing

subscribing

Just wanted to check if there is some news.

subscribing

subscribing

Just discovered this, man it could really help me out. I've subscribed to keep track of the progress -- best of luck! :-)

Subscribing. Also changing title back to a more useful one.

joining the bandwagon

subscribing :-)

looking forward to it!

subscribing

Subscribing!

waiting some news ;)

Saluti
BES

subscribing

Waiting to know more. This module worked brilliant in 4.7, back in the day :)

subscribing

following up too, good luck!

Wish I knew how to port modules!! This would be a great one to have available.

Although I'm rapidly approaching the point where most of my data is imported, I'm still willing to chip in some money in order to see this module upgraded for version 5. Other than custom SQL and import scripts the only other option appears to be importexportapi which isn't exactly for the faint of heart (at least not mine).

I now count 42 people who have "subscribed" to follow this thread. I'm willing to put up $50.00US to help things along. Are any of you willing to put up some money for this feature? Is there anything we can do to help the process along?

Count me in for another 50 bucks (but only if there is a solution in the next few months).

Is there any work in progress on this topic?
If so, could you please post a patch here, or maybe even put it into a DRUPAL-5 cvs branch?

I mailed Robrecht last week offering to help in porting module if possible. Alternatively I'll chip in $50 towards getting a 5.x update out in the next few weeks.

As mentioned above, would be good to see how much work is needed to get it done - a 5.x branch in CVS please?

Another interested drupal user

It surprises me that there is no 5.x branch, and there does not even appear to be an updated "HEAD" version. While I thank the maintainer for such an important module, it is unhelpful that there is no way for someone to look at the current state of progress on the 5.x version of this module. I am prepared to do work to make this work for 5.x within the next couple of days, but apparently I will have to start from the 4.7 version.

Or else look to the script that is available as another support request for this project, which would sadly mean my work would not go towards updating this module properly to 5.x.

To the maintainer: if you have progress towards 5.x, please make it available to us so that we can help.

As far as I can see this is one of the most requested and interesting modules and there is no news for months ...
It would be nice if some other good soul takes over because I guess the current maintainer has no time or no interest anymore. I'll wait another little while and than I'll ask the core developers to have a look at it because this is an important module for many people.

This is no offense but it just takes too long to get a status report or even an intention statement. I really hope the maintainer reads this message to respond to.

Greetz
Jan

FYI, if you want a node import solution for Drupal 5, and you're not afraid to make some simple modifications to PHP code, Victor's script works pretty well. That's what I'm using for a site launch right now. I have significantly modified his script and posted my version after his:

http://groups.drupal.org/node/2197#comment-11129

The code is also attached here. Please see the link above for instructions and context.

@Robrecht: Like ray007 proposed in #46: There are obviously a few developers able to pick up any partially efforts if you would provide a patch. Please let us know if you can provide a (partial) patch or if we should start from scratch.

Attached is a patch that provides a basic port of Node Import module to 5.x. Although there are alternative ways to generate multistep forms in D5, I haven't changed that.

I've successfully imported from arbitrary CSV files into CCK nodes. Please test.

If this patch is fully functional, it will need a bit polishing regarding Drupal coding standards to get committed. After that we can implement an alternative multistep form generation.

Patch doesn't apply correctly. I've applied some parts manually but I can't get it to work. When submitting the first page, I get that page reloaded with the 'File format' field as read-only.

I'm attaching a patch with some more changes in this direction. I've changed some module_exist calls to module_exists, a node_get_name call to node_get_types and a system_listing call to drupal_system_listing.

The patch has been applied to node_import module, branching it for Drupal 5.x. Thanks.

I have not tested it, but there are enough testers here. The development snapshot (node_import-5.x-1.x-dev) will be available soon on the site (waiting for drupal.org to generate it). After enough tests, I'll release the new version once everyone has tested it on this list.

DO NOT USE ON PRODUCTION SITES YET. If you find a bug, create a new issue with the version 5.x-1.x-dev version. Please attach a small, 5 rows, CSV or TSV file that shows the bug when you submit an issue.

I'll keep this issue open until many bugs are fixed.

Thanks all and my apologies for the delay.

Sorry for my late response, my connection broke for a while.

Attached is a patch against 5.x-1.x-dev that fixes some t() calls and makes Node Import use the proper Forms API validation functions. It seems like changes to content.inc also did not get in.

After this one is committed, I'll post a polishing patch regarding Drupal coding standards and coding style.
Sorry for changing version, 5.x-1.x-dev is not in the list.

OT: Don't know why my patch didn't apply, I'm experiencing this not the first time. I'm using TortoiseCVS to create patches. Could it be possible that Windows line endings are the cause?

Forget the last patch. The module needs a complete rewrite to implement proper multistep forms leveraging FAPI.

So this one includes only necessary changes. Some buttons (f.e. Reload) do not work. To make them work, we need proper multistep forms. I'm very busy right now and won't have the time to code that soon. So somebody should take this up. If you do, please assign this issue to yourself first, so others know you're already working on it.

Since 5.x-1.x-dev basically works, I'm setting priority to normal. Do not use on productive sites.

If you find a bug, create a new issue with the version 5.x-1.x-dev version.

I'd rather like to see any upgrade-related bug reports in this issue, so everyone is able to track the process. I certainly won't check the issue queue of Node Import to stumble across issues related to the 5.x port. This issue is about the port for 5.x, so any bugs regarding this port should go in here.

Sun, sorry for the misunderstanding on where to post bug reports for the 5.1 port. I'm following up in this thread with the problem I originally described here:

http://drupal.org/node/141207

I logged out and logged back in as you suggested and the interface will still not move beyond the initial page. Any other ideas? Has anyone installed the module ported to 5.0 and got it working successfully?

Mennonot: you are not the only one. I have the same problem: doesn't advance to next page. I try to figure out why not. There are no entries in the logfiles. File doesn't seem to upload. Settings are the same, though, as for a working 4.7 configuration.

I'm having the same problem. It won't advance past the initial page, after clicking the next button it just reloads the first page. Also if I select a file format that format sticks and I no longer get the option to change it to something else.

Please do not change title and category of this issue.

Since latest node_import.module works in my Drupal test installation and I don't have CVS access to update latest dev, you might try to replace your node_import.module with the file attached to this post (rename to .module of course).

Sun,

Sorry about the title change and thanks for your prompt follow up.

I tried the new file you uploaded and encountered the same error. I noticed that it was identical to the node_import to which I'd applied your May 3, 2007 - 14:36 patch. Was it supposed to be different?

Perhaps its clashing with another module. I have installed. Here's the ones I've currently got enabled:

captcha
calendar
Date API
event
gsitemap
image
img_assist
insert view
nice menu
panels
scheduler
textimage
tinymce
views
webform

tvoorter and alpinemiata, could you also post a list of modules you're using? It might allow us to quickly narrow down any possible conflicts. If no obvious module appers, I may have time to go through and disable each module one by one to check if it is the one causing the conflict.

Sun, thank you for sharing your file. Unfortunately, it didn't do the trick. Autodetect also doesn't function.

Mennonot, for what it's worth, here's my list of modules. It's a very basic setup, because the node_import module is essential for my purpose, and I don't want anything to interfere with it. I'm importing tab delimited files into CCK. Thus, I use a bunch of CCK modules and some Core modules:

CCK:
Content 5.x-1.4
Date
Date API
Fieldgroup
Image
Link
Node Reference
Number
Option Widgets
Text
User Reference
Content Templates

Core:
Comment
Profile
Search
Statistics
Taxonomy
Upload

I'm running Windows 2003 / IIS6 / PHP 5.1.2 / MySQL 4.1.7. I know IIS6 is not an ideal, but normally I don't have much problems with it: importing large TSV files into Drupal 4.7 framework goes very smooth.

I hope this information helps a bit, and I keep you informed if I run into a solution.

Thomas

This is definitely a PHP5 issue. I've switched to PHP5 temporarily and was able to reproduce the described behaviour. Needs further investigation.

Check this. Please apply this patch against the clean, latest development snapshot of 5.x-1.x-dev.

Sun, you really lighten up my day! Fantastic, I applied your new patch and I'm able to import TSV into CCK content type.

These are the features which work:

Use a different file button
Autodetect
Predefined headers are correctly populated -> columns falls in correct CCK field
Add non-existing terms to the vocabulary
Preview Reload button

After import the buttons "Delete CSV file from server and "Download rows with errors" don't work --> blank screen with "Import content" title. Personally, i can live with that for now.

Thank you very much for making this module work!

cheers,

Thomas

Works great for me now, same conclusions that tvoorter noted.

If anyone else is using it to import GMap nodes if you are using Google to georeference the nodes you have to make two columns with nothing but 0's and import them as lat and long (I think I remember seeing a post about this for the 4.x version, but it still stands true for Sun's awesome 5.x port).

Thank you Sun for being so quick with all your help, you definitely need a CVS account for this module. If I run into any other issues I'll post them here.

The mentioned buttons and the button Reload in the Node import preview page will not work until proper multistep forms of Drupal 5 (see this issue) are implemented.

However, IMHO those fixes/optimizations certainly can be implemented at a later time and we can create a 5.x-1.0 release of Node Import now.

Committed to 5.x-1.x. Leaving it open for Robrecht to create and publish a 5.x-1.0 release.

5.x-1.0 has been released. Wait up to 24 hours before it is available on the download page.

just FYI: Stable releases are packaged every 5 minutes.