I'm getting a drush make error when building a site with geofield, using drush 4.4 and drush make 2.2, causing build to fail:

geofield downloaded from http://ftp.drupal.org/files/projects/geofield-7.x-1.0-alpha1.tar.gz.                         [ok]
Found makefile: geofield.make                                                                                         [ok]
No core project specified.                                                                                            [error]

need to add to the make file

projects[] = drupal

Comments

phayes’s picture

phayes commented
Assigned: Unassigned » phayes

Aha. thanks for catching this

phayes’s picture

phayes commented
Status: Active » Needs review

Fixed here: http://drupalcode.org/project/geofield.git/commit/b97a173

Can you please review and confirm that this fix works for you?

phayes’s picture

phayes commented
Status: Needs review » Needs work

From dtarc:

I have been hitting a drush make error on our server:

Found makefile: geofield.make
[ok]
Project information for drupal retrieved.
[ok]
Unable to determine project type for drupal.
[error]

Fatal error: Class 'DrushMakeProject_' not found in
/home/drush/commands/drush_make/drush_make.drush.inc on line 142
Drush command terminated abnormally due to an unrecoverable error.
[error]
Error: Class 'DrushMakeProject_' not found in
/home/drush/commands/drush_make/drush_make.drush.inc, line 142

It's been working locally but won't work on our server.

I have been trying everything I can to patch geofield.make but nothing
seems to be applying.

phayes’s picture

phayes commented
Status: Needs work » Fixed

Okay. I'm pretty sure this is fixed. Feel free to re-open if it is still broken in some instances...

brianfisher’s picture

brianfisher commented
Status: Fixed » Needs work

now I get an error

Directory not empty: /tmp/drush_make_tmp_1302713266/__build__/sites/all/modules/libraries [error]

maybe it's because of this line?

projects[] = libraries

phayes’s picture

phayes commented

Can you clear your /tmp and make sure it's not just some random path collision? Also, what version of drush, drush-make are you running? anything else about your environment that might have an impact?

brianfisher’s picture

brianfisher commented

Ah. I already have the libraries module declared in my makefile. This fails (using drush 4.4 and drush make 2.2):

api = 2
core = 7.x
projects[drupal][type] = core
projects[geofield][type] = module
projects[libraries][type] = module

See http://drupal.org/node/947158

Maybe if you use the full syntax instead of the shorthand?

For now, I can just comment out my libraries declaration, and the build succeeds. Though the build would probably fail if other modules try to include the libraries module...

phayes’s picture

phayes commented

I've opened an issue over at drush-make here: http://drupal.org/node/1128636

pwolanin’s picture

pwolanin commented

duplicate to #1159548: "No core project specified" in a makefile consisting of just a library. ?

phayes’s picture

phayes commented
Status: Needs work » Fixed

This should no longer be an issue as we are not including the make file by default.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.