Closed (outdated)
Project:
Organic Groups
Version:
6.x-2.x-dev
Component:
Og Views
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
15 Apr 2011 at 15:18 UTC
Updated:
27 Oct 2024 at 11:53 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
soulfroysIt works great! Thank you!
(Drupal 6.20, OG 6.x-2.1)
Comment #2
ezra-g commentedMarking as "needs review".
Comment #3
Grayside commentedLooks good. A few standards need tweaking.
No comment describing handler.
Early as possible in the function please. In this case, top of the code block.
Periods
Comment #4
Grayside commentedAdding tag.
Comment #5
soulfroysMarked #888154: no leave group link field in views? as duplicated of this one.
Comment #6
soulfroysHello @Grayside!
I made a patch with the fixes (last dev), but I don't have git, does it help? Works great for me.
Comment #7
Grayside commentedLooking good!
If a user can't leave the group, why show a link at all?
Comment #8
domignon commented#6: og_views-add-leave-group-field-1128492-06.patch queued for re-testing.
Comment #9
soulfroysYes, you're right...
Comment #10
Grayside commentedI would think the leaner UI of not showing anything would be cleaner. Is there a particular reason you feel the verbosity of "Closed" is helpful?
Comment #11
soulfroysWithout the "t('Closed')", the code should look like this:
But it will not show anything, getting a hole in the view:

With the "t('Closed')", looks like this:

@mikestefff, What do you think?
Comment #12
gregglesIt makes sense to me to see "Closed" - otherwise I'd be confused about why I can't leave the group.
Comment #13
Grayside commentedIn that case, does "Closed" really inform you of why you can't leave the group?
Comment #14
mstef commentedAgree something should be said if you can't leave the group, but good point about how "Closed" doesn't really explain anything. Not sure what would work best there.
Comment #15
Grayside commentedRequired
Locked
Comment #16
alexlim commentedHello Guys,
after i patch the og, i added them to as views field but the result end up with duplicated views..distinct not working too..
hope someone can help
Thanks!
Comment #17
Grayside commentedHi @alexlim!
This issue is for a work-in-progress feature request which has work done on it sporadically at best. That you found a bug is not surprising, and will be helpful to any developer that decides to come forward and resume work on this.
In the meantime, the patch is not really supported, and if there are problems with it I recommend you remove it from your codebase.
Comment #18
soulfroys@alexlim, could you please post your Views export and a screenshot of the complete Views-Display?

My view works great:
[EDITED]
Sorry!!! I just fixed the image url...
Comment #19
claudiu.cristeaThis version of Drupal is not supported anymore. If this is still an issue in the
8.x-1.xbranch, please open a new up-to-date ticket. Closing.