I got this error on forward non-node page.

Warning: Cannot modify header information - headers already sent by (output started at /includes/common.inc:2561) in drupal_goto() (line 681 of /includes/common.inc).

Status message is not displayed.

CommentFileSizeAuthor
#4 forward.png2.41 KBsarjeet.singh
#2 forward.patch394 bytessarjeet.singh

Comments

john.oltman’s picture

john.oltman commented

Sarjeet, can you post the URL of the page that has the forward link on a non-node page. Thanks.

sarjeet.singh’s picture

sarjeet.singh commented
Status: Active » Needs review
StatusFileSize
new forward.patch394 bytes

John, I found issue.I made a patch for it. its need to review.

john.oltman’s picture

john.oltman commented
Assigned: Unassigned » john.oltman

Great, thanks sarjeet. In order to test the patch, I'll need to reproduce this error. How did you get Forward links to appear on a non-node page. Do you have a URL I can look at, or some advice for reproducing this? I haven't been able to get non-node links to appear. Any help is appreciated!

sarjeet.singh’s picture

sarjeet.singh commented
StatusFileSize
new forward.png2.41 KB

Please go on forward settings page.(http://www.example.com#overlay=admin/config/user-interface/forward). There is a option Show Forward on non-node pages.please check it and Save configuration. Now forward link will shown on non-node page.

Or you can try this link http://www.example.com/forward?path=<non node url(view or menu callback url)> to produce error.
Please check watchdog there is a php error.

sarjeet.singh’s picture

sarjeet.singh commented

john,
Are you able to reproduce error?

john.oltman’s picture

john.oltman commented
Status: Needs review » Needs work

Just did, working on solution

john.oltman’s picture

john.oltman commented
Status: Needs work » Needs review

Ok, found and fixed the problems and committed to the D7 branch. They will be in the next nightly DEV build. However, I had to use the direct browser URL to try it. I cannot get forward links to appear on non-node pages, either in D6 or D7, and in fact the code doesn't appear to support it directly. Yes, the check box is there (well, it's gone from D7 for now), but the module doesn't do anything based on the box being checked or not, based on my reading of the code and my usage of the module. I am a new maintainer for this module and am mostly helping with the D7 port, so I may be wrong, but that's what it looks like. Can you send me a screenshot of your site's non-node page with the link showing? Did you hard code the link, or is Forward truly outputting the link into non-node content?

john.oltman’s picture

john.oltman commented

@sarjeet.singh: By the way, thanks for the patch, I used it. There were a couple of other errors when using non-node paths, so I fixed those as well.

sarjeet.singh’s picture

sarjeet.singh commented

John.. thanks.

Yes, i did hard code the link. Because forward module didn't provide link on non-node page.

john.oltman’s picture

john.oltman commented
Status: Needs review » Closed (fixed)