JavaScript Tabs

Took a first look through the code ...

- Project title/description okay (could use a screenshot!)
- Translations good.
- Removes variables on uninstall.
- No user output (or related security concerns)
- No db interaction (or related security concerns)
- User indicates how this project differs from a the similar 'dropdown_tabs' module
- Runs cleanly through 'Coder' module (with exception of missing file blocks and CVS 'ID' entry warning)

Issues:
1. Please add a README.txt file.
2. Please add 'description' and 'core' entries in your .info file.
3. Stealing your image from iStockPhoto is likely to come with some serious licensing implications ... please find another image to use. Please provide the image source, and demonstrate confirmation that the image is free from any licensing restrictions and is free for re-use (and may be bundled into your module under the Drupal GPLv2 license).
4. Module should make use of Drupal.behaviors instead of document.ready.
5. Installed on an existing Drupal 6 implementation (default theme), and saw no effect (ie. the module did not replace my tabs). Installed on a Drupal 7 implementation, and saw the rollover icon; but tabs bar was replaced with the word 'array', and no menu was generated.

Suggestions:
1. Project Page: Consider enhancing your description on your sandbox page (which would become the full Drupal.org project page once the module was promoted to full status.)
2. Coding Standards: Please consider adding Doxygen style @file comment entries at the beginning of each module file.
3. js_tabs_preprocess_page is labelled as implementing hook_preprocess_page, but I don't see "hook_preprocess_page" as a function in api.drupal.org

Closing due to inactivity, feel free to re-open if this was a mistake.

Your project page could still be a little more informative (See http://drupal.org/node/997024)

you should only list files[] in your info that contain classes or interfaces

as there is not very much code to review, I'd suggest a single project promotion

automated review:

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
Review of the master branch:

• Drupal Code Sniffer has found some code style issues (please check the Drupal coding standards). See http://ventral.org/pareview/httpgitdrupalorgsandboxsunlight1129934git.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.

Hi there,

It's way too late at night to start a new review right now so I'll just pop this quick comment in here in passing: check out the automated checking of your commit here http://ventral.org/pareview/httpgitdrupalorgsandboxsunlight1129934git there's a few coding standards things to ammend.

Also it seems you still have files other than README.txt in your master branch.

Just a few items to have a look at while you're waiting on a full manual review (I'll leave as needs review so it doesn't drop off the list)

Cheers

Hi, I have installed and tested this module (I will not comment on the code, because I'm getting familiar with the standards used):

• works as described
• Searched module categories for similar projects: Theme Enhancements and Site Navigation, I have not found another module that has the same functionality
• Perhaps the name in the info should be the same as that used in documentation, you know, to avoid confusion. I was looking for js_tabs, no JavaScript Tabs
• Project page, may be appropriate to include a picture, so users can see the new look of the tabs

We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

@Sunlight Studios: Great contribution! I added a couple of major issues to your issue queue. They're not critical, but I think it'd make sense to try to fix those before making a full release.

Setting correct status. See http://drupal.org/node/532400

This module is unreal.

Its quite small, so was pretty easy to read through the code. I manually ran Code Sniffer on each file, without issue. Code is well commented (inline) and reads fine. Theres nothing that would cause any security issues that I could see.

Installed and worked fine on a clean d7 install. Love the option of paths to include/exclude - super handy.

This is a great module and looks (to me at least) that it adheres to all standards.

Hi,

Minor improvement ideas

1. You should add the git clone link on the project issue.

2. There is still a master branch.

3. On the js file you could also add:

(function ($) {
  /* Your code here */
})(jQuery);

4. I would speed up the toggle up animation, it seems quite slow.

5. It would be really nice if this module replaces also the block contextual menus with the same menu.
Right now there is a graphic incoherence with the other menu gears.

Beside that there are no security issues, code is clean and passed coder and ventral tests so I guess this is RTBC.

Nice work, hope you will have time to make the point 5.

First hit on google when typing "drupal git remove master": http://drupal.org/empty-git-master

Wow ... long time. Guess I started the loop on this one, so let me close it. :)

Thanks for your contribution, Sunlight Studios!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.