The module cause my link addition to menu fail [#1135470]

When I tried to add the link to newly created menu, I get following error related to the hierarchical select:

Fatal error: Call to undefined function db_fetch_object() in /home/manveru/www/new.manveru.pl/htdocs/sites/all/modules/hierarchical_select/modules/hs_menu.module on line 91

Call Stack:
    0.0001     663648   1. {main}() /home/manveru/www/new.manveru.pl/htdocs/index.php:0
    0.3849   38754752   2. menu_execute_active_handler() /home/manveru/www/new.manveru.pl/htdocs/index.php:22
    0.3876   39062600   3. call_user_func_array() /home/manveru/www/new.manveru.pl/htdocs/includes/menu.inc:501
    0.3876   39063216   4. drupal_get_form() /home/manveru/www/new.manveru.pl/htdocs/includes/menu.inc:0
    0.3877   39064976   5. drupal_build_form() /home/manveru/www/new.manveru.pl/htdocs/includes/form.inc:188
    2.8036   49404448   6. drupal_process_form() /home/manveru/www/new.manveru.pl/htdocs/includes/form.inc:350
    2.8036   49408336   7. form_builder() /home/manveru/www/new.manveru.pl/htdocs/includes/form.inc:815
    2.8067   49511128   8. form_builder() /home/manveru/www/new.manveru.pl/htdocs/includes/form.inc:1780
    2.8067   49516152   9. form_builder() /home/manveru/www/new.manveru.pl/htdocs/includes/form.inc:1780
    2.8068   49524640  10. form_hierarchical_select_process() /home/manveru/www/new.manveru.pl/htdocs/includes/form.inc:1724
    2.8094   49539736  11. _hierarchical_select_hierarchy_generate() /home/manveru/www/new.manveru.pl/htdocs/sites/all/modules/hierarchical_select/hierarchical_select.module:690
    2.8115   49542960  12. module_invoke() /home/manveru/www/new.manveru.pl/htdocs/sites/all/modules/hierarchical_select/hierarchical_select.module:1616
    2.8115   49543904  13. call_user_func_array() /home/manveru/www/new.manveru.pl/htdocs/includes/module.inc:793
    2.8115   49544240  14. hs_menu_hierarchical_select_root_level() /home/manveru/www/new.manveru.pl/htdocs/includes/module.inc:0

Now I am stucked, because I blocked from adding the link to the menu.

Additionally I am seeing following notices now:

    Notice: Undefined index: #item w hs_menu_form_alter() (linia 41 z /home/manveru/www/new.manveru.pl/htdocs/sites/all/modules/hierarchical_select/modules/hs_menu.module).
    Notice: Undefined index: #item w hs_menu_form_alter() (linia 41 z /home/manveru/www/new.manveru.pl/htdocs/sites/all/modules/hierarchical_select/modules/hs_menu.module).
    Notice: Array to string conversion w _hs_process_attach_css_js() (linia 396 z /home/manveru/www/new.manveru.pl/htdocs/sites/all/modules/hierarchical_select/hierarchical_select.module).
    Notice: Undefined offset: 1 w hs_menu_hierarchical_select_lineage() (linia 114 z /home/manveru/www/new.manveru.pl/htdocs/sites/all/modules/hierarchical_select/modules/hs_menu.module).

Comments

Comment #1

lukpe commented 25 April 2011 at 06:14

I have the same problem, adding menu links works only after disabling Hierarchical Select Menu component...

Comment #2

duckzland commented 28 April 2011 at 07:06

seems the author forget to convert db_fetch_object() to d7 new database api equivalent

this new code for hs_menu.module should fix this problem

/**
 * Implementation of hook_hierarchical_select_root_level().
 */
function hs_menu_hierarchical_select_root_level($params) {
  $menus = array();
	$query = db_select('menu_custom', 'mc');
	$query->fields('mc',array('menu_name'));
	$query->fields('mc',array('title'));
	$query->orderBy('mc.title', '');
	$result = $query->execute();
	foreach ($result as $menu) { $menus[$menu->menu_name . ':0'] = $menu->title; }
  return $menus;
}

Comment #3

manveru commented 28 April 2011 at 07:31

You should post it as a patch.

Comment #4

geerlingguy commented 5 May 2011 at 06:19

Version:

7.x-3.0-alpha1

» 7.x-3.x-dev

Subscribe, moving to -dev. Might post a patch when I get some time.

Comment #5

dafeder

he/him

Philadelphia, PA

commented 3 June 2011 at 19:43

Allowed me to access the page (WSOD before) but now I get a number of php errors, such as:

Notice: Undefined index: #item in hs_menu_form_alter() (line 41 of /XXX/sites/all/modules/hierarchical_select/modules/hs_menu.module).

Comment #6

pepperoni13 commented 5 June 2011 at 03:18

I tried changing the this code snippet in that module and still have an issue when i try to edit a meu link.

Comment #7

puya commented 13 June 2011 at 20:07

I have the same issue. really stuck here with the hs_menu.module line 91

I got the dev version ans I was getting a fatal error. for now disabling the 'hierarchical select menu' works since I dont need it for the menu, just for taxonomy (Although it would be nice to have it on the menu system as well.)

Comment #9

wim leers

Ghent 🇧🇪🇪🇺

commented 28 June 2011 at 16:00

Status:

Active

» Closed (works as designed)

hs_menu has not yet been ported and is marked as such, hence you cannot enable it at admin/build/modules. You should not enable it with force..

Comment #10

geerlingguy commented 28 June 2011 at 22:05

I was able to enable the module at admin/build/modules...

Comment #11

Azamat commented 30 June 2011 at 05:11

Assigned:

Unassigned

» Azamat

what about "?>" at the end of hs_menu.module ????

Comment #12

offerman commented 9 August 2011 at 19:44

Same problem here (as designed :-)
However, was able to enable the Hierarchical Select Menu in the module admin window.
Please don't put it there / disable it if not yet ported, must be confusing a lot of people.

Comment #13

wim leers

Ghent 🇧🇪🇪🇺

commented 10 August 2011 at 09:05

Let's look at modules/hs_menu.info.

In git, HS 7.x-3.x:

name = Hierarchical Select Menu
description = Use Hierarchical Select for menu parent selection.
dependencies[] = hierarchical_select
dependencies[] = menu
package = Form Elements
core = 6.x

In the tarball:

name = Hierarchical Select Menu
description = Use Hierarchical Select for menu parent selection.
dependencies[] = hierarchical_select
dependencies[] = menu
package = Form Elements
core = 6.x

; Information added by drupal.org packaging script on 2011-07-11
version = "7.x-3.0-alpha2"
core = "7.x"
project = "hierarchical_select"
datestamp = "1310423216"

Drupal.org's packaging scripts are to blame for the ability to enable the module.