Single Page Website

Hi Yaremchuck,
you're module meets the coding standards (tested via the coding module).

Can you explain a littlebit more about the module on your site?
How would I configure it etc. I installed it, but had to do too much work on my part to make it work, so I stopped :)

It looks like a nice feature to have, I have not checked it against pre existing work, but I can definitely see the use cases.
nice work.

cheers

Hey Yaremchuck,

I had already installed single_page.
I tried to get it working with a Zen theme, but was not yet sure about wether I did it right.
I then switched to bartik (D7) and uninstalled and then reinstalled. The default values did not reappear, which they should do imo.
I was then able to get them via your attached screenshot, but unfortunately, the page sliding did not work properly, see screenshot attached.
I followed your instructions to the letter.
It seems the module was not able to record height of the nodes properly and there also was some overlap on rows, see other screenshot.

I haven't taken a look at your code yet other than running it through coder, but it seems to me that the functionality should at least work right out of the box as claimed.
I'm willing to help you, so if you can make some more steps we can get this thing on the road :)

that sounds great, let me know how your work goes.
I'm looking forward to your next version.

cheers

Hi Vasily,
I'm currently not able to review due to time constraints, someone else can pick this up and else I'll take a look early next week!

cheers

Dear Yaremchuk
Went through your module demo site, found it really good :) Could not install and test it yet but went through the .module file in quick time.
Here are a few suggestions:
Every function and variable name should be descriptive and start with your module name. This is basically to avoid conflicts and easily differentiate between variables in DB and elsewhere. I find 'single_front_page()', 'single_page_footer' and other variables require change in naming. I suggest something like 'single_page_website_page_footer' should do. Same for the function. See http://drupal.org/coding-standards#naming
It would also be good if you comment all your functions appropriately.(ref function single_front_page())

Would look into more detail soon.

Did you come across
http://drupal.org/project/onepage
It seems abandoned but you may try to contact its maintainer.

Hi Vasili,

I installed the new version. screenshot attached.

I'm thinking that I might be doing something wrong since I can't seem to get it right :)
I'm with bartik unaltered as default them and changed nothing.
The scrolling is working a little bit but it only moves some pixels the first time.
i also see a scrollbar horizontally.

when I use another radiobutton (the bottom one) i have the same issue, but then without scrollbar

can you give some more explanation about what I should be doing?
I'll try to make some different navigation items.

Also I invite other people (like arjit) to take a look since I don't want to be a limiting factor in getting this module approved.
Does it work for others?

Hi Vasili
I installed the module and here is what I did:
-downloaded module from git repository
-extracted and placed it in my D7 fresh installation(minimal)
-enabled module(menu alongside)
-went to the configuration page, Bartik was the only option in the dropdown and selected 'Leave the content as it is, scroll can appear'
-created a content type page and created three posts with menu links(through menu settings in node-edit options)
-three tabs appeared on the top
-went to site information and set the front page as 'single_page'

The front page did not scroll on clicking the tabs for me. I could see tab1 content and could scroll down to see other two nodes.
Cleared the cache but in vain
Tried all the three options one by one.
Nothing worked for me :(
In all the scrolls appeared and disappeared for different options.
Could you please tell me if I missed something in configuration. There is very brief configuration documentation. This was all I could manage.
Your demo site works beautifully. Is it using the same module or has some tweaking done over it?

@rofl would you confirm if you also tried something other than the flow I have listed here. It may help Vasili to gather all the options and procedure we have tried and could not make the module work?

> 'title' => 'Single Page Settings',

Use sentence case in page titles.

> $items['single_page'] = array(
> $items['admin/config/system/single-page'] = array(

Standardize paths - the hyphen form is the more usual.

> $items['admin/config/system/single-page'] = array(

I think this belongs under 'appearance' rather than 'config/system'.

> Default theme will be overwriten, by this selection!

This is scary!!!! overwritten how? I don't see code that looks like it does that, but it sounds like it's going to change my files!

I installed the module successfully. It changes the primary links menu, but not the navigation menu, or links inside the content such as the node author.

Also, having put two items into my primary menu, this appears to work by loading everything and scrolling around.

How scalable is this? I had assumed you'd be using ajax to load pages in as requested -- see http://drupal.org/project/quicktabs for an example of this.

Thanx to joachim's comment, I was able to get the module working-added new terms in the main menu by going to the menu add item link instead of adding it through the node edit page. Not a very user friendly thing for a site that uses 4 nodes as all of content.
Second problem I ran into was that I had some long content in the node body and scrolling was not able to recognize it. It left me in between the content on clicking the next link. (edit+)Also the left navigation block moved along with content.
I think the second problem is kind of #priority to look upon before we move further.

@ joachim: I am not sure AJAX as in quicktabs would apply here too as you can see in the demo site that you can manually scroll down the content if you want. Quicktabs operate on blocks or nodes that uses AJAX on changing the tab. Vasily has suggested this module for small websites(like personal portfolio etc) and I think it should be able to handle 5 to 6 tabs easily. Putting a limit to number of tabs could be an option. Thats my personal opinion.

> Vasily has suggested this module for small websites(like personal portfolio etc) and I think it should be able to handle 5 to 6 tabs easily.

Ah right. I was under the impression that the idea of this module was to do any kind of site with AJAX, the same way twitter works now.

good job Yaremchuk!
I'm going to check it out.
also thanks to other reviewers for stepping in!
seems there's already some people liking your stuff

Hi Vasily
Checked the new version of the module. The scrolling is going right for 'crop text' setting but for the other one, it is still the same(leaves in between the content).
I can now create menu directly from the content edit page and with spaces :)
Another concern I have is the 'crop text' setting. I am attaching a screenshot where you can see it has cropped the line in half :o
Moreover personally I am not very satisfied with this approach. Reason being, once I crop the text I have no link to send the user to the node page to read the full article as the node titles are not clickable by default. The lines cut in half doesn't do any good either.
I suggest to put a read more link there.
A few notes:
A read more link can be ajaxified but then it may land you in same problem of scrolling to the node title.
If it takes you to the node, say node/1, then I noticed that the tabs instead of taking you to the homepage and start their usual scrolling, takes you to respective node pages. eg. go to http://yaremchuk.ru/node/1 and click the tabs. It is not exactly a bug but may be something you would like to pay attention to if you plan implementing read more thing.

Regards
Arijit

Dear Vasily
The module is working perfectly now. Must compliment you for making it work so smoothly :)

Here are last few things I found before changing the application status to RTBC:

-You can remove hook_install rather than commenting text in the function

-You forgot to change the variable names in hook_uninstall :)

-Please run your module through coder on minor setting. A few 'trailing spaces' issues are left.

A personal suggestion, you may change the name of the module in the .info file as single page website than single front page...sounds more descriptive :) Also there are some spellings to be corrected in README.txt ->under CUSTOMIZATION and ROADMAP

Regards

Did you run coder at minor setting?

Thanx for fixing all the coder warnings Vasily :)
I think the module is now quite stable for use.

Hi Vasily,

congrats!
there is a link in your project page that says 'promote to full project status'.
click it and you will be guided through the process

Hi Vasily,
I'm sorry about that, there's another step needed.
the status is now changed to reviewed and tested. Someone with the right permissions will come along and will approve your module so you can then promote it to full project.
This will probably happen in the next few days, so if you can wait a little longer it will be fine.
then the link will show up :)

Hi Vasily
Thanks for coming back to me. I still would like to see this as a module for drupal 6 as well as 7.

Kind Regards
Fiona

Hi Vasily

I am glad to hear that. I can see alot more developers using it, if it has a D6 version. Not everyone is ready to move to D7 in a commercial environment.
I would definitely say zen or fusion, any of the main base themes.

Kind Regards

Fiona

Congratulations, Yaremchuk!  You can now promote sandbox projects to full status ones.  When you would like further review for any project please do ask at http://groups.drupal.org/peer-review/requests

Further issues (for D6 branches and anything else!) can be filed on your project issue queue.  Thank you for your contribution and i look forward to seeing its refinement and development and your continued involvement in Drupal!

_{benjamin, agaric}

Congrates Vasily :)
It was long pending !!!

congrats vasily! thanks for your work and contribution :)

Hi,

First I would like to congratulate everyone and specially Vasily for this great and interesting module. I'm testing it for one of my personal project and it works well, except that some javascript are no more functioning in the single_page view as they do in simple nodes. This is the case for instance with Tipsy (I have tried different types of tooltip scripts too, with same problem).

Could someone explain me why is it such and if a fix can be done?

I have seen that the module has a colorbox fix script. Can something like this be done for Tipsy and others scripts/modules?

Unfortunately, I'm not really a coder and just don't understand what can be done and how.

Thank so much for any help.

Sahaj,
This is already a full project now. You may file this issue under support here http://drupal.org/project/issues/single_page_website?status=All&categori...

I'm having the same issues as @arijit but struggling with the suggestions that were given to him.

I have set everything up - I click on each menu link - it doesn't scroll to the page, the link doesn't even go into the URL bar. Is there any chance anyone could help me?

Thank you!

Please dont hijack the thread....
open a new issue to the projects issue queue here http://drupal.org/project/issues/single_page_website