Unchecking "Create new revision" causes SQL error when Auto-publish is ON [#1139312]

This is for the current git accessible 7.x-1.x-dev, but also occurs for 7.x-1.0-beta3.

A content type has create "New Revision" enabled and "New revision in draft" enabled. If an admin unchecks "New Revision" on node edit the following error will be generated and the node update will not occur.

Status message:
Auto-publishing this revision.
Error message:
Notice: Undefined property: stdClass::$current_revision_id in revisioning_node_update() (line 488 of /var/www/html/sites/all/modules/contrib/revisioning/revisioning.module).
PDOException: SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'vid' cannot be null: UPDATE {node} SET vid = :vid WHERE nid = :nid; Array ( [:vid] => [:nid] => 95 ) in revisioning_node_update() (line 489 of /var/www/html/sites/all/modules/contrib/revisioning/revisioning.module).
The website encountered an unexpected error. Please try again later.

Comments

Comment #1

rdeboer

Melbourne

commented 26 April 2011 at 23:19

Title:	Unchecking "New Revision" causes SQL error	» Unchecking "New Revision" causes SQL error when Auto-publish is ON
Assigned:	Unassigned	» rdeboer

Could reproduce this, but only when Auto-publish is also switched on of for the content type in question.
Looking into a fix now.

Comment #2

rdeboer

Melbourne

commented 26 April 2011 at 23:38

Title:	Unchecking "New Revision" causes SQL error when Auto-publish is ON	» Unchecking "Create new revision" causes SQL error when Auto-publish is ON
Status:	Active	» Fixed

Fixed on master branch, will be in 7.x-1.0-beta4.
it's all a side-effect of having to work around this core D7-only bug #1120272: node object inconsistent after node_load($nid)
:-(