Some file types are added to the media render array as arrays and not objects

I'm having a similar issue.. Not the same though.. http://drupal.org/node/1141536

Hi guys.

Here is the patch, which will fix the error described above.

Fixed patch

Just changing status

i don't get this error on 7.x-2.x. maybe this has been fixed since then?

Subscribe.

I think this gets us at least a little better on track. Tested and works with a .pdf file in the library.

Subscribing.

subscribe

I'm coming from http://drupal.org/node/1252490

I get again the same error using this new version also:
« Notice: Trying to get property of non-object in theme_media_thumbnail() (line 286 di /.../sites/all/modules/media/includes/media.theme.inc). »

In the error box one line for each "other" kind file appears.
I'm going to modify the above file again (with the previous changes I hope).

AFAIK, #8 is unnecessary, as file_view_file() should do that already.

The problem seems to be that media_field_formatter_view() is adding #file as the content of $item, which is an array. Changing this fixes the problem, but I'm not sure what exactly needs fixing as this whole code is supposed to be deprecated... why is it called anyway?

  // @todo Legacy support for the extra formatter added to file fields. See
  //   media_field_formatter_info().
  if ($display['type'] == 'media_large_icon') {
    foreach ($items as $delta => $item) {
      $element[$delta] = array(
        '#theme' => 'media_formatter_large_icon',
        '#file' => $item,
      );
    }
    return $element;
  }

This time I have to edit:

theme_media_thumbnail($variables): ad at row 280
// Fix http://drupal.org/node/1141374
$element['#file'] = (object)$element['#file'];

function template_preprocess_media_thumbnail(&$variables): just rewrite the function in this way:
// Fix http://drupal.org/node/1141374
$element = $variables['element'];
$element['#file'] = (object)$element['#file'];
$variables['element']['#name'] = isset($element['#file']->filename) ? $element['#file']->filename : NULL;

To answer to arthurf message in the post I'm coming from:
"...and I'm unclear why $variables['element']['#file'] would be an array in the first place..."
I don't know, but I can ensure you that it is an array in my page.
Can it depend from another module integration (es: media_youtube, media_browser_plus) or a theme (my theme is made by Artisteer)?

It may be to do with the file object being cast as an array in file_entity_file_formatter_file_field_view().

The notes say:
Set $items to what file field formatters expect. See file_field_load()

So I think that ensuring that the file is cast as an object as in #13 is probably the easiest way to be sure that it doesn't throw the error, but not sure if it is the best way.

Have attached a patch to implement that.

Assigning for review.

I think this should resolve it once and for all.

Tested and confirmed. Committing #18 to 7.x-2.x and 7.x-1.x. Thanks everyone!
http://drupalcode.org/project/media.git/commit/b764d29
http://drupalcode.org/project/media.git/commit/775a93f

I was getting a similar error which caused my thumbnails not to render when I accidentally uninstalled Responsive Image after selecting it as an image style for things in d8. Reinstalling/enabling it did the trick.