I have my site setup so that authenticated users can make changes to nodes but those revisions must be approved and published by an admin before they go live. I was able to get the nodes to correctly work, they still show the old revisions until the new ones are approved. But I have a view that shows node content and they always show the newer unpublished changes in the view even though I have set Filter Criteria to "Content revision: State (= Current, published) "

Also, I'm not sure if it is related, but when a regular user loads a node edit page this error is shown:

Notice: Undefined index: delete in revisioning_form_alter() (line 45 of /sites/all/modules/revisioning/revisioning.pages.inc)

Comments

rdeboer’s picture

rdeboer
Location Melbourne
commented

Hi j0k3z,
Thanks for your report.
The first part of your issue is most likely due to this core issue: #542290: Make it easier to create draft revisions in core.
The second part I'll investigate soon.
Rik

esculcar’s picture

esculcar commented

subscribing

rdeboer’s picture

rdeboer
Location Melbourne
commented
Assigned: Unassigned » rdeboer
Status: Active » Fixed

"... View always shows the newer unpublished changes..."

Do you refer to Revisioning's built-in View at "/content-summary". I assume you do.

On my system (core D7.2 with Revisioning 7.x-1.0-beta7) I cannot reproduce the behaviour you report.
NO entries are shown for nodes that are "Pending" when you select "Current published", which is what it is meant to do.
Basically what it says in the "State" column of the summary table should match what you set in the "State" filter.
Let me know if this is not happening for you.
Otherwise I'll consider this fixed.

PS: the node title and link shown in the content summary table are always referring to the current revision, except when you have configured Revisioning to load the latest revision when the user clicks on a View or Edit link of a node (/admin/config/content/revisioning).

PS2: I cannot reproduce the error in line 45 either...

j0k3z’s picture

j0k3z commented
Status: Fixed » Active

If you setup a view that shows node field content in a table or whatever, then you will see the newest changes even if they are not yet approved, even though the node page itself still correctly shows the older approved content

rdeboer’s picture

rdeboer
Location Melbourne
commented

Ok, I get you now. You are talking about fields other than the basics (like the title, modification date). Yep, that is due to the issue mentioned before. I'll have to work around like I've done elsewhere in Revisioning.

rdeboer’s picture

rdeboer
Location Melbourne
commented
Title: Views always shows latest revision regardless of filters » View always shows latest revision of content fields, regardless of filters
Version: 7.x-1.0-beta4 » 7.x-1.0-beta8
rdeboer’s picture

rdeboer
Location Melbourne
commented
Status: Active » Fixed

Fixed in 7.x-1.0-beta9

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.