Make ui more consistent with other Drupal admin pages
ahoeben - January 31, 2007 - 15:43
| Project: | Taxonomy Batch Operations |
| Version: | 4.7.x-1.3 |
| Component: | User interface |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs work |
Description
- Move checkboxes to the left
see admin/comments, admin/content - Move 'bulk actions' to the top of the page*
see admin/comments, admin/content - Move pager out of the table
see admin/comments, admin/content - Remove '|' between operations**
see admin/blocks - Change header from 'Name' to 'Term name'
see admin/taxonomy/edit/term
*: 'Save' is often found at the bottom of the page. In this case I have kept it on the top of the page near the 'Delete selected' button. Both apply to the same list of terms. I have not put the 'Delete selected' and 'Save changes' options in a dropdown box, because one applies to selected items and the other applies to changed items. This will become more clear if/when more bulk operations are made available
**: The 'delete' operation may be redundant. There's a delete option in the edit form, and we have the delete selected items functionality. In the only other similar form I can find with an edit and delete operation per item (admin/block), there is no other delete option in the edit form or using checkboxes.
#1
forgot the patch...
#2
Yes, the usability consistancy (checkboxes on left, and a bulk operations dropdown box on top) was in the TODO list in the Readme - that's great that you've gone ahead and made the changes.
Thanks for the patch! I'll hopefully have a chance to test it later today.
While we're at it -- I'm not entirely sold on "Occurances" as the column name. I was thinking of renaming it simply "Nodes" (ie. the number of nodes that make use of that term). I've been thinking of revamping the vocabulary overview page with the same treatment as the terms overview page, in which case that column would be called "Terms" (ie. the number of terms in that vocabulary).
Any opinion on that?
#3
Patch looks good, just a couple small issues:
- behaviour for empty vocabularies should be consistant with the core taxonomy module: table should display "No terms available."
- pager display is broken, at least on Blue Marine. Shifted to the far right of page
#4
I am getting to know the module before I embark on the 'merge term' task. Looking into these issues helps me doing that ;-)
Could you specify 'broken'? In most themes the pager is always centered in the content pane. I am not doing anything special with the pager which would make it go to the right of the page, but I don't currently have a site with Blue Marine enabled to test it with.
I'll fix the 'empty vocabulary' behavior tomorrow and make a new patch.
#5
For some reason in Blue Marine it appears on the far right, not sure why.
I recognize that in many places in Drupal the pager is outside of the table, however the taxonomy module has it inside the table with a colspan=2. It does this in both 4.7 and 5. Personally, I would vote to emulate the core taxonomy module's display behaviour in this way -- and if taxonomy.module changes where it puts the pager in the future, we could change to do the same.
Unless you or someone else feels particularly strongly that it should be broken out of the table, in which case I'll concede, but in that case I think it should probably be filed as a UI bug in the core taxonomy issue queue as well ...
#6
... but of course now that the buttons are no longer inside the table, we would want to make it colspan=5
#7
Applied, with empty vocabulary behaviour fixed.
Thanks