Closed (won't fix)
Project:
Drupal.org security advisory coverage applications
Component:
theme
Priority:
Normal
Category:
Task
Reporter:
Anonymous (not verified)
Created:
7 May 2011 at 12:46 UTC
Updated:
3 Aug 2015 at 07:32 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
Anonymous (not verified) commentedI have uploaded mirchi theme on last week. Any update for mirchi project?
Comment #2
jthorson commentedListing your sandbox link in the 'Issues Tags' section doesn't work very well ... clicking it takes me to a 'list of issues tagged with xxx', where xxx is your URL. But no point in making you do this, when I'm already here!
The sandbox link is http://drupal.org/sandbox/vijayveera/1136360
Comment #3
sivaji_ganesh_jojodae commentedI tested this theme in Google chrome 11. It looks okay to me. I noticed some problem with site slogan and primary menu, I have reported the same in project issue queue #1158660: Adding Site slogan breaks primary menu, otherwise it is ready to be marked as RTBC.
P.S : vijayveera is my colleague at E-ndicus.
Comment #4
Anonymous (not verified) commentedI fixed the bug #1158660: Adding Site slogan breaks primary menu. Now it's working good.
Comment #5
Anonymous (not verified) commentedI fixed the bug #1158660: Adding Site slogan breaks primary menu. Now it's working good.
Comment #6
jthorson commentedvijayveera: Please review the information on http://drupal.org/node/317, regarding the project 'issue queue'.
Part of this review process is helping applicants familiarize themselves with the ongoing maintenance of their contributed project ... and as such, I'd encourage you to update the ticket opened by sivaji; to represent the fact that you've addressed the bug. ;)
Comment #7
dreamleafI'm taking a look through the theme and have a couple of things that I will post in the sandbox issue queue shortly.UPDATE
99% of this theme is a straight copy of the Corolla theme http://drupal.org/project/corolla and would be better suited to be submitted as a subtheme of that. Information on creating sub themes can be found @ http://drupal.org/node/225125
The benefit of creating a subtheme instead of just copying the Corolla code and changing references is that you will benefit from the on-going development of Corolla, and you won't need to duplicate the functionality as you have here. Corolla is an excellent design base to subtheme, so you may find that by working 'with it', improvements could be quickly seen at a design level for your theme.
Comment #8
dreamleafSetting status to needs work
Comment #9
dreamleafComment #10
jthorson commentedIn addition, the theme seems to have a 'background' issue with long/wide content. See attached.
Comment #11
tim.plunkettClosing due to inactivity, feel free to re-open if this was a mistake.