Blindtextgenerator

Honestly, currently the queue is around a month. But considering this, if you feel you can confidently contribute to the review process, you are welcome to review other project applications to help reduce the backlog. For information on how to review project applications visit http://drupal.org/node/894256, or to join the Drupal code review group visit http://groups.drupal.org/code-review.

Thanks for your contribution!

Hi,

I don't see how your module is any different than what the Dev module does when generating nodes. Could you explain a bit further?

Sorry, I didn't check out the website.

Hi,

After my mistake, I took some time to review the code in itself.

First, remove the $Id$ lines from the files. CVS is not used anymore.

Then, you MUST add a README.txt file.

Instead of using "implementation of ...", please use "Implements...", according to Doxygen and comment formatting conventions.

In your hook_perm(), you're setting a permission named "blindtextgenerator". Please use a better name for this permission, something like "Use blindtextgenerator" or anything you like.

Line 46, you're checking if user 1 has access twice. Yes, user 1 is user_access' boss, so user_access lets him do anything he wants :). In other words, just using user_access is enough, user 1 will automatically bypass this.

Some small but important comments : lines 44/45 you're not identing your code ; remove the commented code (all these drupal_add_js and stuff) ; why are there a loooot of spaces after '#type' ? ; line 158 extra space after == ;

Well, that's all I could find. I know, I'm petty.

By the way, except for these things, it looks like you've well understood PHP, the Drupal API and the Drupal coding standards. I haven't tested it though, do you have a demo website where to try this?

Hi,

I received your email, I will test this and review your changes asap.

Hi,

I've tested the module on your website, it's really great. I'm impressed.

Concerning git, it looks like you haven't pushed your changes over Drupal repository. I guess they've been commited to your local repository, but you haven't done this :

Pushing your code back to the repository on Drupal.org
git push -u origin master

These instructions are available here for your project : http://drupal.org/project/1102514/git-instructions

Hm, I got that wrong, actually you did commit to Drupal repository, on the remotes/origin/6.x-1.x branch, your changes were just not commited to origin/master.

So, a quick review :

- Remove this LICENSE.txt file, this will be added automatically when promoting your application to full project.
- Good README.txt.
- Remove the version from your .info file, it is now discouraged (see http://drupal.org/node/171205#version).
- Don't add a blank line after the comment about your functions.
- To keep it consistent, line 63, please write "$found = FALSE" instead of "$found=FALSE" (spaces).

Also please apply these changes to origin/master :-)

Hi,

Sorry for taking so long!

I have reviewed and everything seems to be fixed.

Putting this as RTBC, this module works well, no licensing issue, drupal best practices applied, no security flaw found.

Hi,

One of these users have to see this issue : http://groups.drupal.org/node/142454

Then, you'll be able to promote your sandbox project to full project.

You're creating system variables using system_settings_form(). These variables should be deleted in hook_uninstall() so they are removed from the database when your module is uninstalled.

Recommended practice for Drupal projects is to NOT keep any code in the master branch. (Don't delete the master branch, just don't use it.) This is because development snapshots can not be generated from the master branch. For your project, I suggest having a 6.x-1.x branch for the Drupal 6 version of the module, and tagging releases like 6.x-1.0 on that branch. Projects typically just put a README.txt in the master branch explaining that there's no code there and telling the reader to checkout one of the named branches. It appears you had it right in #9 ...

Congratulations sachbearbeiter!

Great work on the persistence and quickly getting to work on every suggestion made. And the uninstall hook for deleting variables looks good!

You are now a vetted git user and can promote sandbox projects to full status ones. When you would like further review for any project please do ask at http://groups.drupal.org/peer-review/requests

Thank you for your contribution and i look forward to seeing your continued involvement in Drupal!

_{benjamin, agaric}